Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguous call to min function #344

Merged
merged 1 commit into from
Mar 11, 2024

Commits on Mar 4, 2024

  1. Fix ambiguous call to min function

    The CsrMV function currently makes a call to min(int, uint32_t).
    Previously, clang headers only defined min(int, int), so this would
    cause the second argument to be implicitly cast to int.
    
    However, in the future Clang will add overloaded versions of min like
    min(uint32_t, uint32_t). This will make the call ambiguous, since the
    compiler does not know whether to cast the first argument to uint32_t,
    or to cast the second argument to int.
    
    This change adds an explicit cast here to prevent future problems.
    umfranzw committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    efc5ddc View commit details
    Browse the repository at this point in the history