.checkTypos: Avoid giving arbitrary strings to gettextf
#6590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
err$message is already translated at this point and may contain printf specifiers. Avoid trying to expand it once again.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6590 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 79 79
Lines 14516 14516
=======================================
Hits 14314 14314
Misses 202 202 ☔ View full report in Codecov by Sentry. |
|
Can you think of a way to regression-test this? I know the OP will be tough since it came from data.table not being attached, what if we have a table with a variable with |
It can't be |
|
Wow, TIL |
MichaelChirico
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #6588,
err$messageis already translated at this point and may contain%. Avoid trying to printf-expand it once again.Fixes: #6588