-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.checkTypos
: Avoid giving arbitrary strings to gettextf
#6590
Conversation
err$message is already translated at this point and may contain printf specifiers. Avoid trying to expand it once again.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6590 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 79 79
Lines 14516 14516
=======================================
Hits 14314 14314
Misses 202 202 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great spot!
Can you think of a way to regression-test this? I know the OP will be tough since it came from data.table not being attached, what if we have a table with a variable with |
It can't be |
Wow, TIL |
As reported in #6588,
err$message
is already translated at this point and may contain%
. Avoid trying to printf-expand it once again.Fixes: #6588