Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.checkTypos: Avoid giving arbitrary strings to gettextf #6590

Merged
merged 5 commits into from
Oct 21, 2024
Merged

.checkTypos: Avoid giving arbitrary strings to gettextf #6590

merged 5 commits into from
Oct 21, 2024

Commits on Oct 21, 2024

  1. Avoid giving arbitrary strings to gettextf 

    err$message is already translated at this point and may contain printf
specifiers. Avoid trying to expand it once again.
    @aitap
    aitap committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    38588c6 View commit details
    Browse the repository at this point in the history

  2. Also don't try translating it

    @MichaelChirico
    MichaelChirico authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    5e05b2e View commit details
    Browse the repository at this point in the history

  3. Add a comment

    @MichaelChirico
    MichaelChirico authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c9c818a View commit details
    Browse the repository at this point in the history

  4. Regression test for .checkTypos

    @aitap
    aitap committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8c57275 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into fix-6588

    @MichaelChirico
    MichaelChirico authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    11c18bd View commit details
    Browse the repository at this point in the history