-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add separate table to store system-cve statuses #1487
Conversation
Commits missing Jira IDs: |
a22bcd0
to
f63bffd
Compare
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
dd4747e
to
0a38605
Compare
288c6d7
to
0f445c2
Compare
0b09762
to
fb1f7e8
Compare
…_cve_data RHINENG-2328
8fc3667
to
6d00a60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, it is pretty good. It is a nice change that the 0
value statuses are implicit and not stored inside the table.
One more question, don't you wanna drop the columns in system_vulnerabilities
table? Or are we just keeping it to being able to roll it back?
I will also test it locally, before merging.
I'd keep status columns in |
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist