Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add separate table to store system-cve statuses #1487

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

jdobes
Copy link
Member

@jdobes jdobes commented Aug 25, 2023

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@jira-linking
Copy link

jira-linking bot commented Aug 25, 2023

Commits missing Jira IDs:
87d1bab
Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-2328

@jdobes jdobes force-pushed the status_table branch 3 times, most recently from a22bcd0 to f63bffd Compare August 25, 2023 14:13
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
common/peewee_model.py 96.57% <100.00%> (+0.09%) ⬆️
manager/cve_handler.py 94.28% <100.00%> (+0.01%) ⬆️
manager/filters.py 96.14% <100.00%> (-0.02%) ⬇️
manager/system_handler.py 98.87% <100.00%> (+<0.01%) ⬆️
manager/vulnerabilities_handler.py 92.30% <100.00%> (+0.03%) ⬆️
taskomatic/jobs/cacheman.py 0.00% <ø> (ø)
taskomatic/jobs/usage_metrics.py 99.32% <ø> (ø)
vmaas_sync/vmaas_sync.py 93.05% <100.00%> (+0.04%) ⬆️
manager/admin_handler.py 68.09% <0.00%> (-0.27%) ⬇️
manager/status_handler.py 95.77% <97.75%> (+4.77%) ⬆️

📢 Thoughts on this report? Let us know!

@jdobes jdobes force-pushed the status_table branch 3 times, most recently from dd4747e to 0a38605 Compare October 10, 2023 15:32
@jdobes jdobes force-pushed the status_table branch 2 times, most recently from 288c6d7 to 0f445c2 Compare October 16, 2023 14:18
@jdobes jdobes force-pushed the status_table branch 4 times, most recently from 0b09762 to fb1f7e8 Compare November 2, 2023 14:58
@jdobes jdobes force-pushed the status_table branch 3 times, most recently from 8fc3667 to 6d00a60 Compare November 2, 2023 16:27
@jdobes jdobes marked this pull request as ready for review November 2, 2023 16:27
@jdobes jdobes requested a review from yungbender November 2, 2023 16:27
@yungbender yungbender self-assigned this Nov 3, 2023
Copy link

@yungbender yungbender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, it is pretty good. It is a nice change that the 0 value statuses are implicit and not stored inside the table.

One more question, don't you wanna drop the columns in system_vulnerabilities table? Or are we just keeping it to being able to roll it back?

I will also test it locally, before merging.

manager/status_handler.py Show resolved Hide resolved
manager/status_handler.py Outdated Show resolved Hide resolved
manager/status_handler.py Outdated Show resolved Hide resolved
@jdobes
Copy link
Member Author

jdobes commented Nov 7, 2023

I'd keep status columns in system_vulnerabilities if we need to rollback. Let's delete it later.

@yungbender yungbender merged commit 6283173 into RedHatInsights:master Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants