Adding Seeking #2160
Adding Seeking #2160
Conversation
automated style fixes Co-authored-by: sanatd33 <[email protected]>
There was a problem hiding this comment.
Hey this looks generally good but can we refactor seeking into a RoleInterface? As much as I dislike RoleInterface this is a lot of code to put straight into this file. Could also use a little more commenting maybe some docs-style stuff explaining what each function does.
automated style fixes Co-authored-by: sanatd33 <[email protected]>
| * The Seeking role provides the implementation for a offensive robot that | ||
| * is trying to get open, so that they can receive a pass | ||
| */ | ||
| class Seeking : public RoleInterface { |
| * is trying to get open, so that they can receive a pass | ||
| */ | ||
| class Seeking : public RoleInterface { | ||
| public: |
There was a problem hiding this comment.
see the GH action warning: explicitly =default the other four required ctors/operators see "rule of five" section here https://en.cppreference.com/w/cpp/language/rule_of_three or ask me for more info
| // The seeker's id | ||
| int robot_id_; | ||
| // The taret point to move to | ||
| rj_geometry::Point target_pt{0.0, 0.0}; |
| */ | ||
| rj_geometry::Point get_open_point(const WorldState* world_state, | ||
| rj_geometry::Point current_position, | ||
| FieldDimensions field_dimensions); |
There was a problem hiding this comment.
| FieldDimensions field_dimensions); | |
| FieldDimensions field_dimensions) const; |
| */ | ||
| rj_geometry::Point get_open_point(const WorldState* world_state, | ||
| rj_geometry::Point current_position, | ||
| FieldDimensions field_dimensions); |
There was a problem hiding this comment.
| FieldDimensions field_dimensions); | |
| const FieldDimensions& field_dimensions); |
| * | ||
| * @return rj_geometry::Point The best point found | ||
| */ | ||
| rj_geometry::Point calculate_open_point(double current_prec, double min_prec, |
There was a problem hiding this comment.
also for both of these member fns make them static if they don't use any members
| * | ||
| * @return rj_geometry::Point The corrected point | ||
| */ | ||
| rj_geometry::Point correct_point(rj_geometry::Point point, FieldDimensions field_dimensions); |
| * | ||
| * @return double The evaluation of that target point | ||
| */ | ||
| double eval_point(rj_geometry::Point ball_pos, rj_geometry::Point current_point, |
automated style fixes Co-authored-by: sanatd33 <[email protected]>
Added hard-coded robot positions in main_window reset method
* added play state to plan request * Fix style * Fix Code Style On add-play-state-to-plan-request (#2166) automated style fixes Co-authored-by: sid-parikh <[email protected]> --------- Co-authored-by: Sid Parikh <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sid-parikh <[email protected]>
sanatd33
force-pushed
the
seeking-test
branch
from
41df6ad to
26c7f7b
Compare
automated style fixes Co-authored-by: sanatd33 <[email protected]>
|
hey @sanatd33 you re-requested my review but didn't address many of the comments from the previous review. please take a look at those when you get a chance. |
automated style fixes Co-authored-by: sanatd33 <[email protected]>
Description
Adds seeking functionality to offense which makes idle robots try to 'get open'.
Associated / Resolved Issue
Resolves https://app.clickup.com/t/86aytmv75
Steps to Test
Expected result: Idle robots should be moving around the field to get open
Key Files to Review
Review Checklist
(Optional) Sub-issues (for drafts)
Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.