-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added behavior for marking enemy robots #2176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic is sound and the demo was impressive! I left a few comments for code quality purposes
780aa29
to
d931867
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for not catching this on my first review. i'll help you with merge conflicts on Tuesday
automated style fixes Co-authored-by: jvogt23 <[email protected]>
f11c243
to
bbc6281
Compare
Description
Describe your pull request.
Added a defensive behavior to mark enemy robots by following them around the field and blocking them from receiving the ball. Currently, it assumes that one marker will be created, and it creates the marker after there are 3 Wallers in play. If more markers are used in the future, logic will have to be added that gives each marker a different target.
Associated / Resolved Issue
Resolves # or ClickUp card
#86ayuj73h
Design Documents
Link
Steps to Test
Test Case 1
Expected result:???
The waller with the highest ID should now be a Marker, and it will follow around the lowest ID'd robot on the other team that is on our side of the field. The Marker will enter a planning state whenever it is searching for a robot to mark, and it will not move during this time. When it finds a robot to mark, it will immediately target that robot.
Key Files to Review
Group 1: Marker classes
Group 2 Defense
Review Checklist
(Optional) Sub-issues (for drafts)
Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.