Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has Open Shot #2178

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Has Open Shot #2178

merged 3 commits into from
Feb 1, 2024

Conversation

sanatd33
Copy link
Contributor

Description

Added function to see if there is open shot

Associated / Resolved Issue

Resolves https://app.clickup.com/t/86az67j9w

Design Documents

Link

Key Files to Review

  • offence.cpp

Review Checklist

  • Docstrings: All methods and classes should have the file appropriate docstrings which follow the guidelines in the "Contributing" page of our docs.
  • Remove extra print statements: Any print statements used for debugging should be removed
  • Tag reviewers: Tag some people for review and ping them on Slack

(Optional) Sub-issues (for drafts)

Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.

  • Step 1
  • Step 2

@sid-parikh sid-parikh merged commit 3748541 into ros2 Feb 1, 2024
2 checks passed
@sid-parikh sid-parikh deleted the has-open-shot branch February 1, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants