Apply suggestions from code review

Co-authored-by: Piotr Rybicki <[email protected]>
RobotecAI · Mar 9, 2023 · 8d201ae · 8d201ae
1 parent 357f69a
commit 8d201ae
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,6 @@
 # Change Log
 
-## [0.12.0] 06 March 2023
+## [0.12.0] 8 March 2023
 
 ### Added
 - ROS2 extension providing a node to publish point cloud into ROS2 topic

diff --git a/README.md b/README.md
@@ -88,7 +88,7 @@ Build instructions:
 1. Install [Microsoft Visual Studio](https://visualstudio.microsoft.com/pl/downloads/) (Visual Studio 2019 when using ROS2 extension) with **C++ CMake tools for Windows** component.
 2. Install [CUDA Toolkit](https://developer.nvidia.com/cuda-downloads) **11.4.4+**.
 3. Download [NVidia OptiX](https://developer.nvidia.com/designworks/optix/downloads/legacy) **7.2**.
-   - use the default location or set environment variable `OptiX_INSTALL_DIR`
+   - install the framework and set environment variable `OptiX_INSTALL_DIR`
 4. Install [Python3](https://www.python.org/downloads/).
 5. Run `x64 Native Tools Command Prompt for VS 20xx` and navigate to RGL repository.
 6. Run `python setup.py --install-deps` command to install RGL dependencies.

diff --git a/include/rgl/api/core.h b/include/rgl/api/core.h
@@ -332,7 +332,7 @@ rgl_entity_set_pose(rgl_entity_t entity, const rgl_mat3x4f *local_to_world_tf);
 
 /**
  * Sets time to the given scene.
- * Time indicates a specific point in time, relative to a clock's 0 point.
+ * Time indicates a specific point in the simulation timeline when raytrace is performed.
  * Timestamp is used to fill field RGL_FIELD_TIME_STAMP_F64 or for ROS2 publishing.
  * @param scene Scene where time will be set. Pass NULL to use the default scene.
  * @param nanoseconds Timestamp in nanoseconds.

diff --git a/setup.py b/setup.py
@@ -132,11 +132,13 @@ def is_cuda_version_ok():
     if on_windows():
         cmake_args.append("-DRGL_BUILD_TOOLS=OFF")  # Tools are not available on Windows
 
+    cmake_args.append(f"-DCMAKE_INSTALL_PREFIX={os.path.join(os.getcwd(), args.build_dir)}")
+
     # Append user args, possibly overwriting
     cmake_args.append(args.cmake)
 
     cmake_args = " ".join(cmake_args)
-    run_subprocess_command(f"cmake -B {args.build_dir} -G {cfg.CMAKE_GENERATOR} --install-prefix {os.path.join(os.getcwd(), args.build_dir)} {cmake_args}")
+    run_subprocess_command(f"cmake -B {args.build_dir} -G {cfg.CMAKE_GENERATOR} {cmake_args}")
     run_subprocess_command(f"cmake --build {args.build_dir} -- {args.build_args}")
 
     if args.with_ros2_standalone: