Allow changing the default Encoding used in S7String #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alize S7String, instead of always using Encoding.ASCII
gfoidl
reviewed
Jun 17, 2022
gfoidl
reviewed
Jun 17, 2022
|
Last time I did a PR the appveyor part also failed. Should I take anything more into consideration when creating the PR? I think it's my fault... |
It's not your fault, and you can't do anything here. The failure is |
scamille
approved these changes
Jun 17, 2022
|
Thx guys. Yes GitVersion has some issues, might look into that at some point... |
|
Released as 0.14.0, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Encoding.ASCII used in S7String to serialize and deserialize strings to/from byte array is not always valid in some situations where you want to use extended ASCII Code Pages, like the Windows 1252, or Iso-8859-1.
This simple PR allows user to change the Encoding system-wide, using an static property directly on the S7String class. I do not know if a central configuration already exists and this setting can be moved there. That would be nicer than this quick'n'dirty fix.