CRT Data Timing

[henrylay97]

Description

As promised at the CM. This PR updates the low-level CRT reconstruction to provide a backup timing reference. Currently the SPEC TDC event trigger is used with the backup being to leave the CRT time in it's raw-est state if the TDC product/channel cannot be found.

This PR adds a first backup of using the PTB HLT before ultimately falling back to the raw-est state if neither can be found. It also makes use of an object provided by @lynnt20 to document this decision on the event.

This branch makes use of Lynn's PMT Decoder PR (#541) and Max's PTB Decoder PR (#581) so the diff includes the updates from those branches too.

Checklist

• Added at least 1 label from available labels.
• Assigned at least 1 reviewer under Reviewers,
• Assigned all contributers including yourself under Assignees
• Linked any relevant issues under Developement
• Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
• Does this affect the standard workflow?

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
No but it does follow updates in the two aforementioned sbndcode PRs.

Link(s) to docdb describing changes (optional)

There will be - I will add it here when it exists.

[RachelCoackley]

trigger build RachelCoackley/larreco>larreco@v09_93_01rachel LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbncode@v09_93_01_p01 SBNSoftware/sbndcode@v09_93_01_01 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_02 SBNSoftware/sbnobj@v09_19_05

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[RachelCoackley]

trigger build RachelCoackley/larreco>larreco@v09_93_01rachel LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbncode@v09_93_01_p02 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_03 SBNSoftware/sbnobj@v09_19_05

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[RachelCoackley]

Hi @henrylay97, the ci_tests show differences, please would you be able to confirm that these are as expected? Thanks!! :)

[henrylay97]

Hi @RachelCoackley, yeah these are mainly as a result of the changes in #540 which this PR is based on. We should double check once the CI has run there but nothing looks surprising to me there!

[RachelCoackley]

@henrylay97 ran the CI on #540 and those ci_tests show the same warnings and product size differences as the ci_tests on this PR. Only differences are in the reco2 files, single_reco2_quick_test_sbndcode and nucosmics_reco2_quick_test_sbndcode. Has the additions of Reco2 | cvn | | art::Assns<recob::Slice,lcvn::Result,void> and Reco2 | cvn | | std::vector<lcvn::Result>

[henrylay97]

Thanks @RachelCoackley interesting that we've picked up the CVN changes. This PR should be held onto until the GDML PR, Lynn's PR etc have been merged. As mentioned on the GDML one I think a stepwise approach will allow us to then review & test these "smaller" PRs.