Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRT Data Timing #582

Closed
wants to merge 263 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
263 commits
Select commit Hold shift + click to select a range
9248e91
Adjust existing modules to uB standard width modules
henrylay97 Sep 26, 2024
434a595
Add square uB modules
henrylay97 Sep 26, 2024
768d686
Add offset
henrylay97 Sep 26, 2024
bd5dfe1
Add skinny modules
henrylay97 Sep 26, 2024
bc8d099
Add offset
henrylay97 Sep 26, 2024
be912d2
Declare uB modules
henrylay97 Sep 26, 2024
c324cc8
Add offset
henrylay97 Sep 26, 2024
3ff3b24
Position top high
henrylay97 Sep 26, 2024
99be2b2
Position top low
henrylay97 Sep 26, 2024
9b12b52
Add offset
henrylay97 Sep 26, 2024
27c2308
Position skinny modules
henrylay97 Sep 26, 2024
3ee2887
Add offset
henrylay97 Sep 26, 2024
e5e7853
Add offset - bottom
henrylay97 Sep 26, 2024
1edf8fd
Correct the problem with order that we had before
henrylay97 Sep 26, 2024
816ea6e
Add missing decleration
henrylay97 Sep 26, 2024
6ff19ce
Offset should be 192 not 212
henrylay97 Sep 26, 2024
2146291
Make it compilable
henrylay97 Sep 26, 2024
24a95c8
Sort out a load of numbering elements
henrylay97 Sep 27, 2024
59fceb0
Keep naming convention consistent
henrylay97 Sep 27, 2024
bae9a3a
Sort out copy numbering
henrylay97 Sep 27, 2024
a326606
Remove extra close statement
henrylay97 Sep 28, 2024
933d140
Correct positioning of modules in north wall
henrylay97 Oct 1, 2024
4f1a876
Correct top low & top high module positions
henrylay97 Oct 1, 2024
9f9f243
Make narrow modules slightly narrower and align to north end
henrylay97 Oct 3, 2024
e6b87c8
Correct offset from north
henrylay97 Oct 3, 2024
e1d9f80
Flip top high
henrylay97 Oct 3, 2024
dfc7116
Ensure NS modules are lower layer, then EW, then EW-central. For the …
henrylay97 Oct 3, 2024
793a045
Position top layers in y
henrylay97 Oct 3, 2024
f4fdbd0
Correctly position top layers in y
henrylay97 Oct 3, 2024
3d737e7
Align skinny modules
henrylay97 Oct 3, 2024
8698b89
Relative separation of top high & low in z
henrylay97 Oct 3, 2024
9246570
Position top layers with respect to pit edge
henrylay97 Oct 4, 2024
fadd85e
You spin my module right round
henrylay97 Oct 4, 2024
b6e2108
Preparsed versions
henrylay97 Oct 4, 2024
893117f
Point at new gdml
henrylay97 Oct 4, 2024
f4acbdf
Ensure SiPMs are at correct ends
henrylay97 Oct 4, 2024
b4986a2
It's never done - someone moved this module
henrylay97 Oct 4, 2024
c7b7ecc
A couple of special case orientations on the north wall
henrylay97 Oct 4, 2024
6875aeb
New channel map for geometry changes
henrylay97 Oct 4, 2024
1eedf3a
Slide (modules 82 & 83) to the right
henrylay97 Oct 5, 2024
46a30ea
Correct top low mapping - thanks Andy
henrylay97 Oct 8, 2024
4aa7d7e
Tidy up for develop
henrylay97 Oct 9, 2024
4d22f93
Separate Data and MC tools
asanchezcastillo Oct 11, 2024
803a3a0
Fix typo
asanchezcastillo Oct 11, 2024
3fe91ca
Fix diig file path
asanchezcastillo Oct 11, 2024
cfc2cae
update RC response to 0.5 ms, add documentation on bad channels
lynnt20 Oct 14, 2024
6fb6cef
add noise filtering only jsonnet configuration
lynnt20 Oct 14, 2024
114a440
update number of ticks
lynnt20 Oct 16, 2024
2d1ba6e
tune coherent noise filtering params
lynnt20 Oct 16, 2024
71a379c
turn on coherent noise filtering for simulation
lynnt20 Oct 16, 2024
dc5fbbe
Merge remote-tracking branch 'origin/develop' into feature/hlay_gdml_…
henrylay97 Oct 18, 2024
e046ed4
Reset the channel map conventions
henrylay97 Oct 18, 2024
69a931f
Add a README for CRT channel mapping
henrylay97 Oct 18, 2024
4c926d0
Point fcl at newest channel map
henrylay97 Oct 18, 2024
c671f66
Update pedestals and timing delays
henrylay97 Oct 18, 2024
00c4748
Ensure all old FEBs are covered
henrylay97 Oct 18, 2024
e896e84
Sort orientation of module 70
henrylay97 Oct 18, 2024
4e80076
Tell the README it can be beautiful
henrylay97 Oct 18, 2024
40a9e58
Update README.md
henrylay97 Oct 19, 2024
b0570af
access raw event header for timestamp in case of multiple tdc ett
lynnt20 Oct 21, 2024
62c9fbb
Move extra Bern module up the list
henrylay97 Oct 21, 2024
cbbc26c
Compile updates
henrylay97 Oct 21, 2024
e374dc2
Update wrappers accordingly
henrylay97 Oct 21, 2024
0d77b8c
Update channel maps accordingly
henrylay97 Oct 21, 2024
a72c8b8
add feature to output waveforms from the timing caen
lynnt20 Oct 21, 2024
6bb9d84
Getting CRT out of the MC calib ntuple for now (geometry conflict fix
linyan-w Oct 23, 2024
48703fd
Merge branch 'develop' into feature/lynnt_pmt_decoder
lynnt20 Oct 24, 2024
6e863fb
Adding fcl for no sce reco2
linyan-w Oct 28, 2024
933ab14
Reverting the standard reco2 fcl
linyan-w Oct 28, 2024
738bfae
Read noise filter parameters from file
asanchezcastillo Oct 30, 2024
c2fd2a5
Fix memory leak
asanchezcastillo Oct 30, 2024
ebb769e
Modify ophitfinder fcl to run on data
asanchezcastillo Oct 30, 2024
a7a51f2
Renaming
asanchezcastillo Oct 30, 2024
86e0bca
Fix fcl for running whole reco chain
asanchezcastillo Oct 30, 2024
c956851
Update root file with latest noise characterization
asanchezcastillo Oct 30, 2024
565094e
Merge branch 'develop' into feature/hlay_gdml_v02_03
bear-is-asleep Oct 30, 2024
4b560a7
Remove cout
asanchezcastillo Oct 31, 2024
8cf658d
add section to make sure NF inherits the right number of ticks
lynnt20 Oct 31, 2024
89a33fb
correct grouping (was missing the last group by accident)
lynnt20 Oct 31, 2024
d2c35ce
Revert "tune coherent noise filtering params"
lynnt20 Oct 31, 2024
0e60a20
turn off coherent NF for simulation again
lynnt20 Oct 31, 2024
c7e4a7a
Widen parent volume for CRT north
henrylay97 Oct 31, 2024
67dc70c
Widen parent volume for CRT tops
henrylay97 Oct 31, 2024
9f50158
Clang build fix
henrylay97 Oct 31, 2024
0db81d8
Remove unnecessary variable
henrylay97 Nov 1, 2024
07f1b77
Merge branch 'develop' into linyan-calib
henrylay97 Nov 1, 2024
66a9bfe
Divide up sequences in workflow
henrylay97 Nov 1, 2024
26d0da7
update params.jsonnet so simulation also inherits the right number of…
lynnt20 Nov 1, 2024
d1be8cb
Further split workflow sequences
henrylay97 Nov 1, 2024
e92d5a5
Make combined reco fcl use workflow thus removing need for reco_sbnd.fcl
henrylay97 Nov 1, 2024
7da6738
Make NO-SCE reco2 fcl for calibrations
henrylay97 Nov 1, 2024
2f11676
Remove unnecessary fcl
henrylay97 Nov 1, 2024
a506e9e
Clean up
henrylay97 Nov 1, 2024
2e176b8
Implementing cleaner suggestion from Dom
henrylay97 Nov 1, 2024
f6d2f36
update RC response value in simulation
lynnt20 Nov 1, 2024
8642baf
actually update RC response value in simulation
lynnt20 Nov 1, 2024
00ffbed
add ellips recomb var fcls and move mod box ones to subdirectory
Nov 6, 2024
9da858e
first commit of PMT timing-related data products with succesful build
lynnt20 Nov 4, 2024
f78ec73
add new board/event timing info, account for second rollover in some …
lynnt20 Nov 4, 2024
89a589c
add usable ptb timing reference, fix bug with tdc calculation
lynnt20 Nov 4, 2024
603513a
add some checks for expected time difference, more corrections for se…
lynnt20 Nov 6, 2024
028f13a
add classes for association pairs, taking examples from lardataobj
tomjunk Nov 7, 2024
ae7faff
fcl to run all the decoders
tbwester Oct 22, 2024
e582850
Accommodate changes to recob::Hit
knoepfel Sep 12, 2024
348a396
Update HitAnalysisAlg.cpp
bear-is-asleep Oct 21, 2024
527094e
update timesize (the size of the frame in samples minus one) to 1143 …
tomjunk Oct 14, 2024
6c6c0ba
fix for running without crt strip hits present
pgreen135 Oct 14, 2024
2503bf9
Save only space points
bear-is-asleep Oct 11, 2024
72fd972
Update drops_reco1.fcl
bear-is-asleep Oct 17, 2024
7160f06
Create a workflow fcl for reco2, mirroring the setup for reco1
absolution1 Oct 4, 2024
b0f5ce2
Add a nominal reco2 drops.
absolution1 Oct 4, 2024
e95c369
Convert reco2 to the new format
absolution1 Oct 4, 2024
ac69fec
Update reco2_data.fcl to use standard_reco2_sbnd.fcl
absolution1 Oct 4, 2024
715b5b4
Update all fcls to use standard_reco2_sbnd.fcl again
absolution1 Oct 4, 2024
8224cfb
Update the readme
absolution1 Oct 4, 2024
50dda18
Remove reco2_sce.fcl
absolution1 Oct 4, 2024
1e4f6ab
Mention SCE being enabled as part of the standard reco2 workflow
absolution1 Oct 30, 2024
4aa0f90
Rename comm fcl to drop 'sce' as its now assumed standard
absolution1 Oct 30, 2024
375ea79
Update fast_simulation_reconstruction_test_electrons.sh
bear-is-asleep Oct 30, 2024
987d31c
Update fast_simulation_reconstruction_test_muons.sh
bear-is-asleep Oct 30, 2024
c4a9c9c
caf fcl for data
Sep 20, 2024
0a3de4c
Update sbndcode/JobConfigurations/standard/caf/cafmakerjob_sbnd_data.fcl
wjdanswjddl Sep 24, 2024
7de50d4
Update sbndcode/JobConfigurations/standard/caf/cafmakerjob_sbnd_data.fcl
wjdanswjddl Sep 24, 2024
b4ab464
cafmaker data calo labels
Sep 25, 2024
14b7d79
filename tag to caf ttree
Oct 16, 2024
c862385
Update to larsoft v09_93_01
Oct 31, 2024
44ed032
Merge branch 'develop' into feature/lynnt_pmt_decoder
lynnt20 Nov 7, 2024
1145650
Thank goodness for the CI
henrylay97 Nov 7, 2024
9754114
save multiple triggerTimeTag for extended waveforms, add rollover che…
lynnt20 Nov 7, 2024
64d70f3
turn on calibrated electronics response by default
lynnt20 Nov 8, 2024
402eae3
Added rawdigit reco files
Nov 12, 2024
7ea4998
Merge branch 'develop' into feature/hjscott1
hjscott1 Nov 12, 2024
413b4da
Moving reco drops to dedicated fcl (that keeps rawdigits)
Nov 13, 2024
427f1c6
Merge remote-tracking branch 'origin/feature/hjscott1' into feature/h…
hjscott1 Nov 13, 2024
5cb6105
Add frequency cutoff option
asanchezcastillo Nov 14, 2024
e85d64d
Merge branch 'develop' into feature/acastill_opdeco_data
asanchezcastillo Nov 14, 2024
966fba3
Fix couts
asanchezcastillo Nov 14, 2024
ef884ad
Fix couts
asanchezcastillo Nov 14, 2024
5a69777
Undo unneccessary changes
asanchezcastillo Nov 14, 2024
b0619a4
Undo unneccessary changes
asanchezcastillo Nov 14, 2024
e37b776
Undo unneccessary changes
asanchezcastillo Nov 14, 2024
d9b7f91
Undo unneccessary changes
asanchezcastillo Nov 14, 2024
ea402c0
Undo unneccessary changes
asanchezcastillo Nov 14, 2024
5565768
Undo unneccessary changes
asanchezcastillo Nov 14, 2024
aa3cc0a
Merge branch 'develop' into feature/hjscott1
hjscott1 Nov 14, 2024
2b4de4c
Merge tag 'v09_93_01_01' into feature/lynnt_pmt_decoder
lynnt20 Nov 14, 2024
53a5962
Merge branch 'develop' into feature/acastill_opdeco_data
asanchezcastillo Nov 15, 2024
ba926dc
Keep CRT tracks in hitdumper by default
bear-is-asleep Nov 15, 2024
1dc4916
Add masked channels list
asanchezcastillo Nov 18, 2024
ecf3335
Add masked channels list
asanchezcastillo Nov 18, 2024
0f084ee
Update sbndcode/Commissioning/fcls/hitdumpermodule.fcl
bear-is-asleep Nov 18, 2024
58615f7
Initial commit of Varuna's work on CVN.
yangtj207 Nov 20, 2024
755083f
Add new fcl files for cvn training.
yangtj207 Nov 20, 2024
bdca27d
Add association between recob::Slice and lcvn::SBNDPixelMap.
yangtj207 Nov 21, 2024
d931f6b
Reorganize fcl files.
yangtj207 Nov 21, 2024
b49d2d0
Add association between lcvn::SBNDPixelMap and lcvn::Result.
yangtj207 Nov 21, 2024
d84f99c
Add a method to make pixel map from slice and evaluate it.
yangtj207 Nov 22, 2024
ee79009
add analyzer to read pmt metric objects (from data)
lynnt20 Nov 22, 2024
03e675a
Add analyzer module to test CVN performance.
yangtj207 Nov 24, 2024
0fdc4b8
Save cvn scores in a TTree.
yangtj207 Nov 24, 2024
5b47729
Modify threshold
asanchezcastillo Nov 25, 2024
eeb059f
de-capitalize Services and change ticks to 3427 for new data
tomjunk Nov 25, 2024
df46aaa
Include PMT reco in standard data reco1 workflow
asanchezcastillo Nov 26, 2024
551f6c1
Add a new version of tf_graph that takes inputs as an input.
yangtj207 Nov 26, 2024
7d42178
Specify inputs and outputs names.
yangtj207 Nov 26, 2024
cb6ef0a
Add fcl file to evaluation cvn and save a tree.
yangtj207 Nov 26, 2024
ce97422
Update to sbnd_data v01_26_00
bear-is-asleep Nov 27, 2024
84ca167
Use model in sbnd_data.
yangtj207 Nov 29, 2024
2f1a5d9
Add truth variables to ttree.
yangtj207 Nov 29, 2024
48b898a
Use new version of sbnd_data.
yangtj207 Nov 29, 2024
74ef75c
Add nhits for each plane.
yangtj207 Nov 30, 2024
306c3c9
Set t0 correction to true.
yangtj207 Nov 30, 2024
2ee6e1f
Add subrun.
yangtj207 Dec 1, 2024
943841f
Save space for reco1 data stage by dropping cluster3d
Dec 3, 2024
0ed20a3
add option to save bes/etrig
lynnt20 Dec 5, 2024
ec379e8
remove default instance name
lynnt20 Dec 5, 2024
230f6f7
Add FileCatalogMetadataSBN.
yangtj207 Dec 9, 2024
a3025e6
Use slice by default.
yangtj207 Dec 9, 2024
65db190
Reduce printouts.
yangtj207 Dec 9, 2024
e9da2fa
Add cvn to MC workflow.
yangtj207 Dec 9, 2024
6736081
Loop over all slices.
yangtj207 Dec 9, 2024
74417fb
Add cvn to reco2_data.fcl.
yangtj207 Dec 9, 2024
18898e4
Change lcvn::SBNDPixelMap to lcvn::PixelMap. Use association to get s…
yangtj207 Dec 9, 2024
3c453ca
Clean up code.
yangtj207 Dec 9, 2024
fe17b06
add option to read metrics even when instance is empty
lynnt20 Dec 10, 2024
80197be
Merge remote-tracking branch 'origin/feature/lynnt_pmt_decoder' into …
henrylay97 Dec 13, 2024
094fe9f
first commit of metric filter
lynnt20 Dec 13, 2024
d5f3626
fix typo
lynnt20 Dec 13, 2024
d223fe4
move the timing reference objects to a new directory, and fiddle with…
lynnt20 Dec 13, 2024
f5e4aa6
Merge branch 'v09_93_01_01p01rc' into feature/lynnt_wirecell_data
bear-is-asleep Dec 16, 2024
53a713b
Update sbndcode/OpDetAnalyzer/PDSAnalyzer/job/run_sbndpds_ana_data_wi…
asanchezcastillo Dec 17, 2024
b2945a4
Update sbndcode/OpDetReco/OpDeconvolution/job/sbnd_ophitfinder_deco_d…
asanchezcastillo Dec 17, 2024
53fee2c
Update sbndcode/OpDetReco/OpDeconvolution/job/opdeconvolution_sbnd_da…
asanchezcastillo Dec 17, 2024
db28e7e
Update run_sbndpds_ana_data.fcl
asanchezcastillo Dec 17, 2024
0d020f4
Update sbndcode/OpDetReco/OpDeconvolution/Alg/opdeconvolution_alg_dat…
asanchezcastillo Dec 17, 2024
c48802d
Update opdeconvolution_sbnd_data.fcl
asanchezcastillo Dec 17, 2024
fdc2ffc
Update OpDeconvolutionAlgWienerData_tool.cc
asanchezcastillo Dec 17, 2024
215a900
Update opdeconvolution_alg_data.fcl
asanchezcastillo Dec 17, 2024
58aafb7
move the timing reference objects to a new directory, and fiddle with…
lynnt20 Dec 13, 2024
75f91d5
Improve time referencing - check TDC is closest to event header and a…
henrylay97 Dec 17, 2024
1e0d223
Merge remote-tracking branch 'origin/feature/lynnt_pmt_decoder' into …
henrylay97 Dec 17, 2024
98eb199
Merge remote-tracking branch 'origin/feature/maxd_PTBDecoderUpdate' i…
henrylay97 Dec 17, 2024
09c59bb
Re-add debugging statements
henrylay97 Dec 17, 2024
775c95c
Make a few reversions from Max's branch
henrylay97 Dec 17, 2024
85f90c0
Remove debug prints
henrylay97 Dec 17, 2024
8678fc5
Add bookkeeping object
henrylay97 Dec 17, 2024
659f066
Update OpDeconvolutionAlgWienerData_tool.cc
asanchezcastillo Dec 17, 2024
e44b07d
Update OpDeconvolutionAlgWienerData_tool.cc
asanchezcastillo Dec 17, 2024
9d59667
Update OpDeconvolutionAlgWienerData_tool.cc
asanchezcastillo Dec 17, 2024
ef8cf44
Correct use of allowed PTBs
henrylay97 Dec 17, 2024
578bc62
Add timing documentation to ana module
henrylay97 Dec 17, 2024
77d6944
Merge remote-tracking branch 'origin/feature/maxd_PTBDecoderUpdate' i…
henrylay97 Dec 17, 2024
2036bd5
add caen9 MSUM channel to default config, fix bug with else if block
lynnt20 Dec 17, 2024
d8a201d
add fcl for running the filter
lynnt20 Dec 18, 2024
d97f22d
Bugfix
asanchezcastillo Dec 18, 2024
50a1c95
Turn off produces line if not referencing
henrylay97 Dec 18, 2024
1026f54
Merge branch 'v09_93_01_01p01rc' into feature/lynnt_pmtmetricsana
lynnt20 Dec 18, 2024
818182c
Merge pull request #568 from SBNSoftware/feature/lynnt_wirecell_data
bear-is-asleep Dec 18, 2024
c4f8680
Merge branch 'v09_93_01_01p01rc' into feature/hlay_gdml_v02_03
bear-is-asleep Dec 18, 2024
21b04cf
Merge pull request #569 from SBNSoftware/feature/hlay_gdml_v02_03
bear-is-asleep Dec 18, 2024
69883fe
Merge branch 'v09_93_01_01p01rc' into feature/lynnt_pmt_decoder
bear-is-asleep Dec 18, 2024
bb6e745
Merge pull request #570 from SBNSoftware/feature/lynnt_pmt_decoder
bear-is-asleep Dec 18, 2024
0cf8a8c
Merge branch 'v09_93_01_01p01rc' into linyan-calib
bear-is-asleep Dec 18, 2024
08cda45
Merge pull request #571 from SBNSoftware/linyan-calib
bear-is-asleep Dec 18, 2024
db3d0cf
Merge branch 'v09_93_01_01p01rc' into feature/munjung-ellips_recomb_v…
bear-is-asleep Dec 18, 2024
e5055e6
Merge pull request #572 from SBNSoftware/feature/munjung-ellips_recom…
bear-is-asleep Dec 18, 2024
b27aef1
Merge branch 'v09_93_01_01p01rc' into feature/lynnt_elecresp
bear-is-asleep Dec 18, 2024
c3eed20
Merge pull request #573 from SBNSoftware/feature/lynnt_elecresp
bear-is-asleep Dec 18, 2024
1b9b8d0
Merge branch 'v09_93_01_01p01rc' into feature/hjscott1
bear-is-asleep Dec 18, 2024
5be3db7
Merge pull request #574 from SBNSoftware/feature/hjscott1
bear-is-asleep Dec 18, 2024
3d69dde
Merge branch 'v09_93_01_01p01rc' into feature/hitdumper_keepcrttracks
bear-is-asleep Dec 18, 2024
b390236
Merge pull request #575 from SBNSoftware/feature/hitdumper_keepcrttracks
bear-is-asleep Dec 18, 2024
138d987
Merge branch 'v09_93_01_01p01rc' into trj_evdfcl_nov25_2024
bear-is-asleep Dec 18, 2024
33d3afc
Merge pull request #576 from SBNSoftware/trj_evdfcl_nov25_2024
bear-is-asleep Dec 18, 2024
6393d80
Merge branch 'v09_93_01_01p01rc' into feature/bearc_sbnddata
bear-is-asleep Dec 18, 2024
7b56fa4
Merge pull request #577 from SBNSoftware/feature/bearc_sbnddata
bear-is-asleep Dec 18, 2024
63c6c90
Merge branch 'v09_93_01_01p01rc' into feature/acastill_opdeco_data
bear-is-asleep Dec 18, 2024
eabf50d
Merge pull request #578 from SBNSoftware/feature/acastill_opdeco_data
bear-is-asleep Dec 18, 2024
f9c0bf7
Merge branch 'v09_93_01_01p01rc' into feature/tjyang_cvn
bear-is-asleep Dec 18, 2024
91e48cc
Merge pull request #579 from yangtj207/feature/tjyang_cvn
bear-is-asleep Dec 18, 2024
4550141
Merge branch 'v09_93_01_01p01rc' into feature/bearc_supera_data
bear-is-asleep Dec 18, 2024
6343031
Merge pull request #580 from SBNSoftware/feature/bearc_supera_data
bear-is-asleep Dec 18, 2024
22d9b1d
Merge branch 'v09_93_01_01p01rc' into feature/maxd_PTBDecoderUpdate
bear-is-asleep Dec 18, 2024
b46f156
Merge pull request #583 from SBNSoftware/feature/maxd_PTBDecoderUpdate
bear-is-asleep Dec 18, 2024
0ecbe7c
Merge branch 'v09_93_01_01p01rc' into feature/lynnt_pmtmetricsana
bear-is-asleep Dec 18, 2024
f32d41b
Merge pull request #585 from SBNSoftware/feature/lynnt_pmtmetricsana
bear-is-asleep Dec 18, 2024
3fca121
Merge branch 'v09_93_01_01p01rc' into feature/hlay_crt_data_timing
henrylay97 Dec 19, 2024
8305300
Update CMakeLists.txt - slipped through the conflict resolving
henrylay97 Dec 19, 2024
1057e8f
Unnecessary
henrylay97 Dec 19, 2024
32cb7ff
Fix signedness
henrylay97 Jan 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ find_package( larcore REQUIRED )
find_package( larcorealg REQUIRED )
find_package( larcoreobj REQUIRED )
find_package( larreco REQUIRED )
find_package( larrecodnn REQUIRED )
find_package( larana REQUIRED )
find_package( PostgreSQL REQUIRED )
find_package( hep_concurrency REQUIRED )
Expand Down
4 changes: 4 additions & 0 deletions sbndcode/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ add_subdirectory(ShowerAna)
add_subdirectory(Commissioning)
add_subdirectory(Trigger)
add_subdirectory(PTBAna)
add_subdirectory(Timing)

# subdirectory for gallery stuff
add_subdirectory(gallery)
Expand All @@ -41,3 +42,6 @@ add_subdirectory(WireCell)

add_subdirectory(Decoders)
add_subdirectory(ChannelMaps)

# for CVN
add_subdirectory(SBNDCVN)
19 changes: 18 additions & 1 deletion sbndcode/CRT/CRTAna/CRTAnalysis_module.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
#include "sbndcode/CRT/CRTBackTracker/CRTBackTrackerAlg.h"
#include "sbndcode/CRT/CRTUtils/CRTCommonUtils.h"
#include "sbndcode/Decoders/PTB/sbndptb.h"
#include "sbndcode/Timing/SBNDRawTimingObj.h"

namespace sbnd::crt {
class CRTAnalysis;
Expand Down Expand Up @@ -94,7 +95,7 @@ class sbnd::crt::CRTAnalysis : public art::EDAnalyzer {
std::string fMCParticleModuleLabel, fSimDepositModuleLabel, fFEBDataModuleLabel, fCRTStripHitModuleLabel,
fCRTClusterModuleLabel, fCRTSpacePointModuleLabel, fCRTTrackModuleLabel, fTPCTrackModuleLabel,
fCRTSpacePointMatchingModuleLabel, fCRTTrackMatchingModuleLabel, fPFPModuleLabel, fPTBModuleLabel,
fTDCModuleLabel;
fTDCModuleLabel, fTimingReferenceModuleLabel;
bool fDebug, fDataMode, fNoTPC, fHasPTB, fHasTDC;

TTree* fTree;
Expand All @@ -104,6 +105,8 @@ class sbnd::crt::CRTAnalysis : public art::EDAnalyzer {
int _run;
int _subrun;
int _event;
int _crt_timing_reference_type;
int _crt_timing_reference_channel;

//mc truth
std::vector<int16_t> _mc_trackid;
Expand Down Expand Up @@ -331,6 +334,7 @@ sbnd::crt::CRTAnalysis::CRTAnalysis(fhicl::ParameterSet const& p)
fPFPModuleLabel = p.get<std::string>("PFPModuleLabel", "pandora");
fPTBModuleLabel = p.get<std::string>("PTBModuleLabel", "ptbdecoder");
fTDCModuleLabel = p.get<std::string>("TDCModuleLabel", "tdcdecoder");
fTimingReferenceModuleLabel = p.get<std::string>("TimingReferenceModuleLabel", "crtstrips");
fDebug = p.get<bool>("Debug", false);
fDataMode = p.get<bool>("DataMode", false);
fNoTPC = p.get<bool>("NoTPC", false);
Expand All @@ -346,6 +350,8 @@ sbnd::crt::CRTAnalysis::CRTAnalysis(fhicl::ParameterSet const& p)
fTree->Branch("run", &_run);
fTree->Branch("subrun", &_subrun);
fTree->Branch("event", &_event);
fTree->Branch("crt_timing_reference_type", &_crt_timing_reference_type);
fTree->Branch("crt_timing_reference_channel", &_crt_timing_reference_channel);

if(!fDataMode)
{
Expand Down Expand Up @@ -621,6 +627,17 @@ void sbnd::crt::CRTAnalysis::analyze(art::Event const& e)

if(fDebug) std::cout << "This is event " << _run << "-" << _subrun << "-" << _event << std::endl;

_crt_timing_reference_type = -1;
_crt_timing_reference_channel = -1;

art::Handle<raw::TimingReferenceInfo> TimingReferenceHandle;
e.getByLabel(fTimingReferenceModuleLabel, TimingReferenceHandle);
if(TimingReferenceHandle.isValid())
{
_crt_timing_reference_type = TimingReferenceHandle->timingType;
_crt_timing_reference_channel = TimingReferenceHandle->timingChannel;
}

if(fHasPTB)
{
// Get PTBs
Expand Down
1 change: 1 addition & 0 deletions sbndcode/CRT/CRTReco/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ art_make_library(

simple_plugin(
CRTStripHitProducer module
artdaq_core::artdaq-core_Data
sbnobj::SBND_CRT
sbnobj::SBND_Timing
sbndcode_GeoWrappers
Expand Down
1 change: 0 additions & 1 deletion sbndcode/CRT/CRTReco/CRTClusterCharacterisationAlg.h
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ namespace sbnd::crt {

CRTGeoAlg fCRTGeoAlg;

bool fUseT1;
double fTimeOffset;
double fOverlapBuffer;
double fPEAttenuation;
Expand Down
Loading