zhang19 gaia names

[LishaRamon]

Short description: Changing two Gaia names

Gaia J0452-36A should be Gaia EDR3 4818823636756117504
Gaia J0452-36B should be Gaia EDR3 4818823808553134592
The Gaia J names should be removed.

Link to relevant issue: Closes #245

For data ingests:

• includes modified JSON files
• Update the Versions table

[LishaRamon]

There is no gaia_j0452-36a json file found to modify.

[kelle]

Then I guess we should ingest it.

Here's the original paper.
https://academic.oup.com/mnras/article/489/1/1423/5545604

[LishaRamon]

How can I run/check that the json file edit was implemented in the db?

[LishaRamon]

Then I guess we should ingest it.

Here's the original paper. https://academic.oup.com/mnras/article/489/1/1423/5545604

Ingest using a new file or is there an existing file to add to?

[kelle]

I'm not sure I understand the question. The JSON file modification is changing the database. If you want to see the change in the change in the DB browser, you reload the database. That will generate a new SQLite file using the JSON files.

[LishaRamon]

That's what I thought too and reloaded the db. Unless I misunderstood what you meant by changing the names. I added 'Gaia EDR3 4818823808553134592' as another name under 'Gaia J0452-36B'.

Or does it mean to delete the 'Gaia J0452-36B.json' file and create a new one with the name 'Gaia EDR3 4818823808553134592'?

[LishaRamon]

Then I guess we should ingest it.

Here's the original paper. https://academic.oup.com/mnras/article/489/1/1423/5545604

This paper is already ingested. Is gaia_j0452-36a and gaia_j0452-36b supposed to be two sources from the same paper? 36b is there but no json for 36a.

[kelle]

It might have gotten changed back when you merged. The way you had it originally was correct

[kelle]

Yes, two sources from the same paper.

[LishaRamon]

It does not pass the test when changing the source because it says there is no Gaia EDR3 4818823808553134592 in the Source table, just the first name.

[LishaRamon]

I attempted making a json file for gaia 36a, but the ra, dec, equinox, and spectral type code are wrong. I only got the spectral type string and changed the source name. In the paper it seems like I have to convert the coordinates data into decimal before I can ingest them.

[LishaRamon]

Table 1 Data

[kelle]

• The separation in arcseconds (115.3) goes in the Companion Relationships table.
• you could also add the T_eff, metallicty (Fe/H), gravity (logg), and mass to the Modeled Parameters table.

[kelle]

Might as well also do the photometry. The relevant filters names from the Photometry Filters table are:

• Gaia2.G
• Gaia2.Gbp
• Gaia2.Grp
• VHS J = VISTA.J
• VHS K = VISTA.K_s
• WISE.W1
• WISE.W2

[kelle]

Suggested change

	"comments": null,
	"comments": "[Fe/H]",

[LishaRamon]

Tests for data and integrity are failing completely at the moment

[kelle]

Looks great!