Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zhang19 gaia names #438

Merged
merged 13 commits into from
Dec 27, 2023
Merged

zhang19 gaia names #438

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0f1d08c
test
LishaRamon Dec 13, 2023
ece0ef9
Changed gaia36b json name
LishaRamon Dec 22, 2023
5d6adb6
Corrected name changes
LishaRamon Dec 22, 2023
6614007
Merge branch 'main' into zhang19-gaia
LishaRamon Dec 22, 2023
9977f17
Initial change
LishaRamon Dec 22, 2023
c1ead7c
gaia 36a attempt
LishaRamon Dec 22, 2023
ffa9835
Update gaia a and b info
LishaRamon Dec 26, 2023
3c3d70b
added parallax/proper motion, passed tests
LishaRamon Dec 26, 2023
f9c1274
Added modeled parameters + separation arcsec
LishaRamon Dec 26, 2023
3c9d7fa
Added Photometry
LishaRamon Dec 26, 2023
7e81706
Updated suggestions
LishaRamon Dec 26, 2023
58bdde6
Updated telescope errors
LishaRamon Dec 26, 2023
702ce6c
Update photometry band names +working tests
LishaRamon Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 69 additions & 1 deletion data/gaia_j0452-36b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"Sources": [
{
"source": "Gaia J0452-36B",
"source": "Gaia EDR3 4818823808553134592",
"ra": 73.1904,
"dec": -36.1448,
"epoch": null,
Expand All @@ -12,11 +12,79 @@
"comments": null
}
],
"CompanionRelationships": [
{
"companion_name": "Gaia EDR3 4818823636756117504",
"projected_separation_arcsec": 115.3,
"projected_separation_error": null,
"relationship": "Child",
"comments": "Spectral Type: esdM1",
"reference": "Zhan19.1423",
"other_companion_names": "Gaia J0452-36A"
}
],
"ModeledParameters": [
{
"parameter": "T eff",
"value": 2600.0,
"value_error": 100.0,
"unit": "K",
"comments": null,
"reference": "Zhan19.1423"
},
{
"parameter": "log g",
"value": 5.5,
"value_error": 0.2,
"unit": "dex",
"comments": null,
"reference": "Zhan19.1423"
},
{
"parameter": "mass",
"value": 0.0855,
"value_error": 0.0014,
"unit": "M_jup",
kelle marked this conversation as resolved.
Show resolved Hide resolved
"comments": null,
"reference": "Zhan19.1423"
},
{
"parameter": "metallicity",
"value": -1.4,
"value_error": 0.2,
"unit": "Fe/H",
kelle marked this conversation as resolved.
Show resolved Hide resolved
"comments": null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"comments": null,
"comments": "[Fe/H]",

"reference": "Zhan19.1423"
}
],
"Names": [
{
"other_name": "Gaia J0452-36B"
},
{
"other_name": "Gaia EDR3 4818823808553134592"
}
],
"Parallaxes": [
{
"parallax": 7.134,
"parallax_error": 0.506,
"adopted": true,
"comments": null,
"reference": "Zhan19.1423"
}
],
"ProperMotions": [
{
"mu_ra": 147.52,
"mu_ra_error": 0.79,
"mu_dec": -168.07,
"mu_dec_error": 1.00,
"adopted": true,
"comments": null,
"reference": "Zhan19.1423"
}
],
"SpectralTypes": [
{
"spectral_type_string": "esdL0",
Expand Down
2 changes: 1 addition & 1 deletion tests/test_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def test_proper_motion_refs(db):
def test_parallax_refs(db):
# Test total odopted measuruments
t = db.query(db.Parallaxes).filter(db.Parallaxes.c.adopted == 1).astropy()
assert len(t) == 1443, f'found {len(t)} adopted parallax measuruments.'
assert len(t) == 1444, f'found {len(t)} adopted parallax measuruments.'

ref = 'GaiaDR3'
t = db.query(db.Parallaxes).filter(db.Parallaxes.c.reference == ref).astropy()
Expand Down
Loading