Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The hpxcxx script was broken such that it could only compile for _release #6306

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

stevenrbrandt
Copy link
Member

The hpxcxx script was broken such that it could only compile for _release. This modification makes it more robust in finding a compiled hpx installation and changes the 2 character flags to use -- instead of -.

Fixes #

Proposed Changes

  • Changes 2 character flags so that they use -- instead of -
  • Fixes bug which prevents non-release versions from working
  • Makes specifying the release optional
  • corrects relwithdebinfo to relwithdebuginfo

Any background context you want to provide?

Checklist

Not all points below apply to all pull requests.

  • I have added a new feature and have added tests to go along with it.
  • I have fixed a bug and have added a regression test.
  • I have added a test using random numbers; I have made sure it uses a seed, and that random numbers generated are valid inputs for the tests.

…ease. This modification makes it more robust in finding a compiled hpx installation and changes the 2 character flags to use -- instead of -.
cmake/templates/hpxcxx.in Outdated Show resolved Hide resolved
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Jul 25, 2023

bors merge

@bors
Copy link

bors bot commented Jul 25, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@stevenrbrandt stevenrbrandt merged commit 5d5dbb1 into master Jul 25, 2023
17 checks passed
@stevenrbrandt stevenrbrandt deleted the fix-hpxcxx branch July 25, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants