run all the jobs for sp7 #637
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmueller
force-pushed
the
full_sp7
branch
2 times, most recently
from
1994258 to
9b80bec
Compare
dirkmueller
force-pushed
the
full_sp7
branch
from
9b80bec to
e0d5679
Compare
dcermak
force-pushed
the
full_sp7
branch
2 times, most recently
from
0edc9c3 to
bdb2bf3
Compare
grisu48
previously requested changes
Jan 23, 2025
| @@ -172,20 +173,6 @@ jobs: | |||
| os_version: 15.4 | |||
| - toxenv: metadata | |||
| os_version: 15.4 | |||
| - toxenv: all | |||
There was a problem hiding this comment.
Accidental removal?
At least from the PR description it doesn't become clear why this part of the CI got cropped.
There was a problem hiding this comment.
no it's not accidental, the all environment should be running by default already
There was a problem hiding this comment.
nit: it would be nice to split into another commit with proper justification.
alexandrevicenzi
previously approved these changes
Jan 23, 2025
| @@ -172,20 +173,6 @@ jobs: | |||
| os_version: 15.4 | |||
| - toxenv: metadata | |||
| os_version: 15.4 | |||
| - toxenv: all | |||
There was a problem hiding this comment.
nit: it would be nice to split into another commit with proper justification.
dirkmueller
force-pushed
the
full_sp7
branch
2 times, most recently
from
73d94ec to
a256fe4
Compare
grisu48
reviewed
Jan 28, 2025
The all environment is run by default anyway, no need to add it explicitly into the test matrix
dirkmueller
dismissed stale reviews from grisu48 and alexandrevicenzi
via
9d10883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probably a bit too early to enable it, so just as a test that can be manually triggered for now.