Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run all the jobs for sp7 #637

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ jobs:
matrix:
toxenv: ${{fromJson(needs.gentestmatrix.outputs.matrix)}}
os_version:
- 15.5
- 15.6
- 15.7
- "tumbleweed"
include:
- toxenv: fips
Expand Down Expand Up @@ -172,20 +172,6 @@ jobs:
os_version: 15.4
- toxenv: metadata
os_version: 15.4
- toxenv: all
Copy link
Contributor

@grisu48 grisu48 Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental removal?

At least from the PR description it doesn't become clear why this part of the CI got cropped.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it's not accidental, the all environment should be running by default already

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it would be nice to split into another commit with proper justification.

os_version: "15.6"
- toxenv: node
os_version: "15.7"
- toxenv: base
os_version: "15.7"
- toxenv: minimal
os_version: "15.7"
- toxenv: metadata
os_version: "15.7"
- toxenv: python
os_version: "15.7"
- toxenv: repository
os_version: "15.7"
- toxenv: all
os_version: "16.0"
- toxenv: base
Expand Down
Loading