Visual datapath upgrade #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion that uses datapath_state
src/emulation_core/mips/line_info.rs
Outdated
| @@ -330,3 +333,314 @@ impl VisualDatapath for MipsDatapath { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| pub fn visual_line_to_data(variable: &str, datapath_state: &UseReducerHandle<DatapathReducer>) -> LineInformation { | |||
There was a problem hiding this comment.
Where do you think we should be handling the switch between MIPS and RISC-V? We're probably going to have a lot of similar variables and it might be cool to just have the UI call the same visual_line_to_data() function and have that function determine which value to use based on the value of datapath_state.current_architecture. It wouldn't require any code changes here but I'm curious what you think.
There was a problem hiding this comment.
I considered that as well but didn't know if we were keeping architecture-specific logic in their own modules. I'm open to either but I do like the compressed version of a single go-to function better. I've added it now and stuck it in utils.rs.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works, but makes the
VisualDatapathtrait redundant by adding a publicvisual_line_to_datafunction that uses the Datapath Reducer's state.