Pseudo-Instructions, test cases, and bug fixes #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmckinley
requested changes
Mar 12, 2024
src/bin/main.rs
Outdated
| @@ -38,7 +41,8 @@ use yew_hooks::prelude::*; | |||
| // To load in the Fibonacci example, uncomment the CONTENT and fib_model lines | |||
| // and comment the code, language, and text_model lines. IMPORTANT: | |||
| // rename fib_model to text_model to have it work. | |||
| const CONTENT: &str = include_str!("../../static/assembly_examples/floating_point.asm"); | |||
| const CONTENT: &str = include_str!("../../static/assembly_examples/riscv_test.asm"); | |||
There was a problem hiding this comment.
Can you add some sort of toggle to the interface so we can switch between RISC-V and MIPS modes? I don't really care who does it or where but it's something that we should probably have at this point.
There was a problem hiding this comment.
I put that there so the frontend would implement the toggle/dropdown as they wished.
There was a problem hiding this comment.
In that case, do you mind switching this back to a MIPS example just to make it a little easier to debug the rest of the program in the meantime?
brooksmckinley
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.