Raise a helpful error when a datatype cannot be found in a schema #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mialy-defelice
suggested changes
Sep 6, 2023
GiaJordan
force-pushed
the
develop-node-error-FDS-955
branch
from
7533074
to
b661938
Compare
GiaJordan
changed the base branch from
develop
to
develop-bugfix-class-in-schema-FDS-1005
GiaJordan
force-pushed
the
develop-node-error-FDS-955
branch
from
9f1096e
to
0f95ba9
Compare
|
🎉 All dependencies have been resolved ! |
Base automatically changed from
develop-bugfix-class-in-schema-FDS-1005
to
develop
September 8, 2023 16:25
|
@GiaJordan Lets add a test to check that this results in the intended error. |
|
@andrewelamb thanks sounds good |
|
@andrewelamb I've added a test to ensure the exception gets raised in the correct circumstances. Could you please review when you have the time? Thanks! |
andrewelamb
approved these changes
Sep 14, 2023
mialy-defelice
approved these changes
Sep 15, 2023
This was referenced Sep 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the linked issue, the error arose because the data type was not spelled according to the conventions of the class label in the schema. The error raised by
networkx:return self._nodes[n] \ KeyError: 'AssayRNASeqMetadataTemplate'was not very good at communicating what was going wrong. I've wrapped another error around this message for the case of generating a manifest that should be more explanatory and offers suggestions for remedying.Depends on: #1287