Fix distributed child nodes side effects #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By sorvell: (Polymer's team member) "[...] The 'ready' method cannot be used with code that depends on the state of external elements, e.g. children or distributed elements or parent. The element is not guaranteed to be in the dom when ready is called. Instead, ready is the signal that the element's internal state is ready for use, its shadowRoot, event listeners, property observers, and bindings. Instead you should use the 'attached' method for this type of thing. When attached is called, the element is in the dom tree. Further, it's best to go asynchronous when accessing external dom. This ensures any element upgrades have been processed. This way you are independent of upgrade ordering. [...]" more info: Polymer/polymer#414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By sorvell: (Polymer dev team member)
"[...] The 'ready' (or created) method cannot be used with code that depends
on the state of external elements, e.g. children or distributed elements or
parent. The element is not guaranteed to be in the dom when ready is
called. Instead, ready is the signal that the element's internal state is
ready for use, its shadowRoot, event listeners, property observers, and
bindings.
Instead you should use the 'attached' method for this type of thing. When
attached is called, the element is in the dom tree. Further, it's best to
go asynchronous when accessing external dom. This ensures any element
upgrades have been processed. This way you are independent of upgrade
ordering. [...]"
more info: Polymer/polymer#414
This change is