Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix distributed child nodes side effects #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix distributed child nodes side effects #201

wants to merge 1 commit into from

Commits on Aug 9, 2017

  1. Fix distributed child nodes side effects 

    By sorvell: (Polymer's team member)

"[...] The 'ready' method cannot be used with code that depends
on the state of external elements, e.g. children or distributed elements or
parent. The element is not guaranteed to be in the dom when ready is
called. Instead, ready is the signal that the element's internal state is
ready for use, its shadowRoot, event listeners, property observers, and
bindings.

Instead you should use the 'attached' method for this type of thing. When
attached is called, the element is in the dom tree. Further, it's best to
go asynchronous when accessing external dom. This ensures any element
upgrades have been processed. This way you are independent of upgrade
ordering. [...]"

more info: Polymer/polymer#414
    @raphael-kikuchi
    raphael-kikuchi authored Aug 9, 2017
    Configuration menu
    Copy the full SHA
    c279349 View commit details
    Browse the repository at this point in the history