-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve method ambiguity with SciMLOperators #1766
Conversation
getting unrelated error (locally) Ambiguity Tests: Test Failed at /Users/vp/.julia/dev/OrdinaryDiffEq/test/interface/ambi
guity_tests.jl:2
Expression: isempty(Test.detect_ambiguities(OrdinaryDiffEq))
Evaluated: isempty(Tuple{Method, Method}[(\(W::OrdinaryDiffEq.StaticWOperator, v) in
OrdinaryDiffEq at /Users/vp/.julia/dev/OrdinaryDiffEq/src/derivative_utils.jl:19, \(d1
, d2::IntervalSets.Domain) in DomainSets at /Users/vp/.julia/packages/DomainSets/lfFfE/
src/generic/setoperations.jl:305)]) ────────────────59]]]]]]]]]]]]]]]]]]]]]3]9]]]]]]]1641]37]35]]0]]]]]21]0]]]]] ueryDas5ypeof(O_PRECS)rd},thing,fEq.REC//10fals Val{orardyDf.r(u,rnyEqas0fs tn pfrnyfq
Stacktrace:
[1] top-level scope
@ ~/.julia/juliaup/julia-1.8.1+0.aarch64/share/julia/stdlib/v1.8/Test/src/Test.jl:46
4
[2] include(mod::Module, _path::String)
@ Base ./Base.jl:419
[3] include(x::String)
@ Main.var"##348" ~/.julia/packages/SafeTestsets/A83XK/src/SafeTestsets.jl:23
[4] macro expansion
@ ~/.julia/dev/OrdinaryDiffEq/test/runtests.jl:63 [inlined]
[5] macro expansion
@ ~/.julia/juliaup/julia-1.8.1+0.aarch64/share/julia/stdlib/v1.8/Test/src/Test.jl:13
57 [inlined]
[6] top-level scope
@ ~/.julia/dev/OrdinaryDiffEq/test/runtests.jl:63
Test Summary: | Fail Total Time
Ambiguity Tests | 1 1 1.4s
ERROR: LoadError: Some tests did not pass: 0 passed, 1 failed, 0 errored, 0 broken.
in expression starting at /Users/vp/.julia/dev/OrdinaryDiffEq/test/runtests.jl:16
ERROR: Package OrdinaryDiffEq errored during testing ``` |
When run with SciML/SciMLBase.jl#210 branch Ambiguity Tests: Test Failed at /Users/vp/.julia/dev/OrdinaryDiffEq/test/interface/ambiguity_tests.jl:2
Expression: isempty(Test.detect_ambiguities(OrdinaryDiffEq))
Evaluated: isempty(Tuple{Method, Method}[(*(W::OrdinaryDiffEq.WOperator, x::Union{Number, AbstractVecOrMat}) in OrdinaryDif
fEq at /Users/vp/.julia/dev/OrdinaryDiffEq/src/derivative_utils.jl:374, *(L::SciMLOperators.AbstractSciMLOperator, λ::Number)
in SciMLOperators at /Users/vp/.julia/packages/SciMLOperators/045lQ/src/basic.jl:203)]) ``` |
@ChrisRackauckas any way these tests can be sped up. Waiting in queue for the past hour now :// |
tests passing locally except for the iffy norecompile test |
@ChrisRackauckas not sure why workflows aren't running, buildkite ran with just one error (in /test/gpu/autoswitch.jl which also errors on master for me so is unrelated to this PR). So this PR should be good to go |
buildkite link: https://buildkite.com/julialang/ordinarydiffeq-dot-jl/builds/1416#_ |
@ChrisRackauckas this is good. the failing check is a timeout in loading delaydiffeq |
rerunning CI. hopefully delaydiffeq workflow will load |
the delaydiffeq test is just timing out: Run julia-actions/setup-julia@v1
Error: connect ETIMEDOUT 146.75.30.49:443 |
@ChrisRackauckas can we just merge? |
ok the delaydiffeq test ran and passed. |
@ChrisRackauckas can we merge? The multithreading CI has passed before. no idea why it's been loading for the past 4 hours |
ok the multithreading CI also passed lets goo |
this is to catch a method ambiguity arising in SciML/SciMLBase.jl#210.
Eventual plan is to define WOperator with SciMLOperators tooling but this quickfix should be good for now