switch to scimloperators #210
Conversation
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 54.69% 55.29% +0.59%
==========================================
Files 40 38 -2
Lines 2938 2769 -169
==========================================
- Hits 1607 1531 -76
+ Misses 1331 1238 -93
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This is missing the deprecation paths. At least #183 needs to be in here. |
|
ok lemme do that. unrelated, should we require |
|
No. We should allow it but not require it. |
src/problems/basic_problems.jl
Outdated
| if A isa AbstractMatrix | ||
| LinearProblem{true}(MatrixOperator(A), b, args...; kwargs...) |
|
anything else to add chris? |
|
what does this error mean @ChrisRackauckas [3f19e933] + p7zip_jll
Updating registry at `~/.julia/registries/General`
Updating git-repo `[https://github.com/JuliaRegistries/General.git`](https://github.com/JuliaRegistries/General.git%60)
No Changes to `~/work/SciMLBase.jl/SciMLBase.jl/downstream/Project.toml`
No Changes to `~/work/SciMLBase.jl/SciMLBase.jl/downstream/Manifest.toml`
ERROR: LoadError: KeyError: key UUID("7ed4a6bd-45f5-4d41-b270-4a48e9bafcae") not found
Stacktrace:
[1] getindex
@ ./dict.jl:481 [inlined]
[2] getindex
@ /opt/hostedtoolcache/julia/1.7.3/x64/share/julia/stdlib/v1.7/Pkg/src/Types.jl:273 [inlined]``` |
|
Did you find/replace and change the name in the Project.toml? Is SciMLOperators in the Project.toml now pointing to the wrong UUID? |
|
do deprecations as follows: const DiffEqArrayOperator = MatrixOperator
function DiffEqArrayOperator(args...)
@warn "SciMLBase.DiffEqArrayOperator is deprecated.
Use SciMLOperators.MatrixOperator instead"
MatrixOperator(args...)
end |
.github/workflows/Downstream.yml
Outdated
| - {user: SciML, repo: LinearSolve.jl, group: All} | ||
| - {user: SciML, repo: NonlinearSolve.jl, group: All} | ||
| - {user: SciML, repo: Optimization.jl, group: All} | ||
| - {user: SciML, repo: Integrals.jl, group: All} | ||
| - {user: SciML, repo: DiffEqSensitivity.jl, group: All} | ||
| - {user: SciML, repo: ModelingToolkit.jl, group: All} | ||
| - {user: SciML, repo: DiffEqOperators.jl, group: All} |
There was a problem hiding this comment.
These shouldn't be removed.
|
nonlinearsolve error should be fixed by SciML/NonlinearSolve.jl#90 |
|
The only test failing for OrdinaryDiffEq is if VERSION >= v"1.8"
@test 2t1 < t3 # FAILING
@test t2 < t4
integ = init(lorenzprob, Rosenbrock23())
@test integ.f.f isa SciMLBase.FunctionWrappersWrappers.FunctionWrappersWrapper
endin No Recompile Tests: Test Failed at /Users/vp/.julia/dev/OrdinaryDiffEq/test/interface/n
orecompile.jl:27
Expression: 2t1 < t3
Evaluated: 1.42499375 < 1.280234125
Stacktrace:
[1] macro expansion
@ ~/.julia/juliaup/julia-1.8.1+0.aarch64/share/julia/stdlib/v1.8/Test/src/Test.jl:46
4 [inlined]
[2] top-level scope
@ ~/.julia/dev/OrdinaryDiffEq/test/interface/norecompile.jl:27
Test Summary: | Pass Fail Total Time
No Recompile Tests | 2 1 3 12.4s
ERROR: LoadError: Some tests did not pass: 2 passed, 1 failed, 0 errored, 0 broken.
in expression starting at /Users/vp/.julia/dev/OrdinaryDiffEq/test/runtests.jl:16
ERROR: Package OrdinaryDiffEq errored during testing |
|
SciML/OrdinaryDiffEq.jl#1766 should fix errors in OrdinaryDiffEq / Integrators / 1 test, SciMLSensitivity / All / 1, StochasticDiffEq / Interface3/ 1 |
|
[ci-skip] |
|
some of these workflows have been stuck for ~50 mins. closing this PR for a moment so workflows can start on other PR |
|
closing this so workflows don't run. need SciML/OrdinaryDiffEq.jl#1766 first |
|
retriggering CI after ordinarydiffeq merge |
|
good, previous errors are resolved. :D new error: OrdinaryDiffEq / Interface / 1 looks like we're converting a sparse matrix into a dense one here Linear Solver Tests: Error During Test at /home/runner/.julia/packages/SafeTestsets/A83XK/src/SafeTestsets.jl:25
Got exception outside of a @test
LoadError: MethodError: no method matching KLU.KLUFactorization(::Matrix{Float64})
Closest candidates are:
KLU.KLUFactorization(::Any, ::Any, ::Any, ::Any) at ~/.julia/packages/KLU/JK7t1/src/KLU.jl:187
KLU.KLUFactorization(::SparseArrays.SparseMatrixCSC{Tv, Ti}) where {Tv<:Union{Float64, ComplexF64}, Ti<:Union{Int32, Int64}} at ~/.julia/packages/KLU/JK7t1/src/KLU.jl:221
Stacktrace:
[1] init_cacheval(alg::LinearSolve.KLUFactorization, A::Matrix{Float64}, b::Vector{Float64}, u::Vector{Float64}, Pl::LinearSolve.InvPreconditioner{LinearAlgebra.Diagonal{Float64, Vector{Float64}}}, Pr::LinearAlgebra.Diagonal{Float64, Vector{Float64}}, maxiters::Int64, abstol::Float64, reltol::Float64, verbose::Bool, assumptions::LinearSolve.OperatorAssumptions{Nothing})
@ LinearSolve ~/.julia/packages/LinearSolve/tyXtB/src/factorization.jl:311SciMLSensitivity / All / 1 ERROR: LoadError: Package SciMLSensitivity errored during testing (received signal: KILL) |
|
This will not be accepted without a clean diff. There seems to be a lot broken in here too, I'm not convinced there aren't merge issues. |
|
there definitely are merge issues - there were many changes in the code base during the past month. i think it would be easier to just start a new. |
SciML/SciMLOperators.jl#55