chore: also use signoz_api_key from connection params

[raj-k-singh]

Summary

Includes SigNoz API key connection param when generating AWS account connection url

Related Issues / PR's

contributes to https://github.com/SigNoz/engineering-pod/issues/2023

---

Important

Add support for signoz_api_key in AWS connection parameters, updating UI and logic to handle the new field.

• Behavior:
  • Include signoz_api_key in connection parameters check in RenderConnectionFields.
  • Add input field for signoz_api_key in RenderConnectionFields if not present.
  • Update useIntegrationModal to include signoz_api_key in agent_config when generating connection URL.
• Types:
  • Add signoz_api_key to ConnectionParams in aws.ts.

^{This description was created by for 067f41c. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 067f41c in 1 minute and 29 seconds

More details

• Looked at 54 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 7 drafted comments based on config settings.

1. frontend/src/container/CloudIntegrationPage/HeroSection/components/RenderConnectionParams.tsx:17

• Draft comment:
  Ensure that the additional check for signoz_api_key in line 17 is intended to hide the entire form if the key exists. This might inadvertently prevent editing when it's already set.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 20% <= threshold 50%
  The comment is asking the author to confirm their intention regarding the behavior of the code. It suggests that the check might prevent editing, which is a specific concern. However, it still falls under the rule of not asking the author to confirm their intention. Therefore, it should be removed.

2. frontend/src/hooks/integrations/aws/useIntegrationModal.ts:142

• Draft comment:
  Ensure signoz_api_key is correctly passed in the payload. The current logic falls back to values.signoz_api_key if not provided by connectionParams; verify that the form field name aligns with this.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

3. frontend/src/types/api/integrations/aws.ts:6

• Draft comment:
  Type definition update for signoz_api_key looks fine; ensure corresponding backend changes support the new field.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  This comment is asking the PR author to ensure that corresponding backend changes support the new field. This falls under the rule of not asking the author to ensure behavior is intended or tested. Therefore, this comment should be removed.

4. frontend/src/container/CloudIntegrationPage/HeroSection/components/RenderConnectionParams.tsx:14

• Draft comment:
  Including signoz_api_key in the conditional check ensures all required fields are provided. The logic is consistent with previously handled fields.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  This comment is purely informative and does not provide any actionable feedback or suggestions for improvement. It simply states that the logic is consistent with previous fields, which does not align with the rules provided.

5. frontend/src/container/CloudIntegrationPage/HeroSection/components/RenderConnectionParams.tsx:52

• Draft comment:
  The new Form.Item for signoz_api_key is correctly added and conditionally rendered when missing, matching the pattern of other fields.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  This comment is purely informative, stating that the new Form.Item is correctly added and rendered. It doesn't provide any actionable feedback or suggestions for improvement.

6. frontend/src/hooks/integrations/aws/useIntegrationModal.ts:143

• Draft comment:
  The agent_config payload now includes signoz_api_key using connectionParams fallback, which ensures the parameter is propagated appropriately.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  This comment is purely informative, explaining a change in the payload structure. It does not provide a suggestion, ask for confirmation, or highlight a potential issue.

7. frontend/src/types/api/integrations/aws.ts:7

• Draft comment:
  The ConnectionParams interface now includes signoz_api_key, updating the type definitions to match the new functionality.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  This comment is purely informative, stating a change in the interface without providing any actionable feedback or suggestions. It does not align with the rules for useful comments.

Workflow ID: wflow_XcM0EEolU2XnccQE

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.