Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: also use signoz_api_key from connection params #7061

Merged
merged 1 commit into from
Feb 7, 2025
+13 −1
Merged

chore: also use signoz_api_key from connection params #7061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...tend/src/container/CloudIntegrationPage/HeroSection/components/RenderConnectionParams.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ function RenderConnectionFields({
isConnectionParamsLoading ||
(!!connectionParams?.ingestion_url &&
!!connectionParams?.ingestion_key &&
!!connectionParams?.signoz_api_url)
!!connectionParams?.signoz_api_url &&
!!connectionParams?.signoz_api_key)
) {
return null;
}
Expand Down Expand Up @@ -48,6 +49,15 @@ function RenderConnectionFields({
<Input placeholder="Enter SigNoz API URL" disabled={isFormDisabled} />
</Form.Item>
)}
{!connectionParams?.signoz_api_key && (
<Form.Item
name="signoz_api_key"
label="SigNoz API KEY"
raj-k-singh marked this conversation as resolved.
Show resolved Hide resolved
rules={[{ required: true, message: 'Please enter SigNoz API Key' }]}
>
<Input placeholder="Enter SigNoz API Key" disabled={isFormDisabled} />
</Form.Item>
)}
</Form.Item>
);
}
Expand Down
1 change: 1 addition & 0 deletions frontend/src/hooks/integrations/aws/useIntegrationModal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ export function useIntegrationModal({
ingestion_url: connectionParams?.ingestion_url || values.ingestion_url,
ingestion_key: connectionParams?.ingestion_key || values.ingestion_key,
signoz_api_url: connectionParams?.signoz_api_url || values.signoz_api_url,
signoz_api_key: connectionParams?.signoz_api_key || values.signoz_api_key,
},
account_config: {
regions: includeAllRegions ? ['all'] : selectedRegions,
Expand Down
1 change: 1 addition & 0 deletions frontend/src/types/api/integrations/aws.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ export interface ConnectionParams {
ingestion_url?: string;
ingestion_key?: string;
signoz_api_url?: string;
signoz_api_key?: string;
}

export interface GenerateConnectionUrlPayload {
Expand Down
Loading