Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: minimum version check #1578

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

JacoKoster
Copy link
Contributor

Fixes #1573

@tkurki tkurki added the feature label Jul 18, 2023
@tkurki tkurki changed the title Fix: Minimum version check Feature: minimum version check Jul 18, 2023
bin/signalk-server Outdated Show resolved Hide resolved
bin/signalk-server Outdated Show resolved Hide resolved
@JacoKoster JacoKoster requested a review from tkurki July 20, 2023 07:18
@tkurki tkurki merged commit e25ac27 into SignalK:master Jul 20, 2023
@tkurki
Copy link
Member

tkurki commented Jul 20, 2023

Fyi @sailoog @mgrouch

@mgrouch
Copy link

mgrouch commented Jul 20, 2023

@tkurki

BBN Marine OS is already with node 18 and SignalK 2.0

@sailoog
Copy link
Contributor

sailoog commented Jul 20, 2023

Thanks for notifying. We already changed from node 16 to node 18 in openplotter-signalk-installer v3.2.0. Any existing node 16 installation is converted to a node 18 installation silently. Any queryable setting would help automate this process, any ideas?

@tkurki
Copy link
Member

tkurki commented Jul 20, 2023

What would like to query?

@tkurki
Copy link
Member

tkurki commented Jul 20, 2023

New downloads being on node 18 is one thing. There’s also existing installations: if somebody just updates their existing setup’s sk their system will break if min nodejs check is not met. Not that this PR changes much: older versions will break anyway, this just gives a nicer log message.

@sailoog
Copy link
Contributor

sailoog commented Jul 20, 2023

What would like to query?

recommended node version

New downloads being on node 18 is one thing. There’s also existing installations: if somebody just updates their existing setup’s sk their system will break if min nodejs check is not met. Not that this PR changes much: older versions will break anyway, this just gives a nicer log message.

yes, and that is solved in openplotter v3 because we decide when to publish a new openplotter-signalk-installer package containing the new recommended node version. Node and sk will update without breaking anything but it could take some days until we realize that you changed the recommended version, so a system to check this could be nice to automatically update existing systems.

@tkurki
Copy link
Member

tkurki commented Jul 21, 2023

I think the recommendation changes so infrequently that we can do with just keeping syncing between people. And recommendation not being 100% up to date is not crucial.

@JacoKoster JacoKoster deleted the min-server-check branch September 9, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a node.js min version check
4 participants