-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: minimum version check #1578
Conversation
BBN Marine OS is already with node 18 and SignalK 2.0 |
Thanks for notifying. We already changed from node 16 to node 18 in openplotter-signalk-installer v3.2.0. Any existing node 16 installation is converted to a node 18 installation silently. Any queryable setting would help automate this process, any ideas? |
What would like to query? |
New downloads being on node 18 is one thing. There’s also existing installations: if somebody just updates their existing setup’s sk their system will break if min nodejs check is not met. Not that this PR changes much: older versions will break anyway, this just gives a nicer log message. |
recommended node version
yes, and that is solved in openplotter v3 because we decide when to publish a new openplotter-signalk-installer package containing the new recommended node version. Node and sk will update without breaking anything but it could take some days until we realize that you changed the recommended version, so a system to check this could be nice to automatically update existing systems. |
I think the recommendation changes so infrequently that we can do with just keeping syncing between people. And recommendation not being 100% up to date is not crucial. |
Fixes #1573