Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: minimum version check #1578

Merged
merged 2 commits into from
Jul 20, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
MAdded distinction between minimum and recommended version
JacoKoster committed Jul 18, 2023
commit 706633943fa643e9eb5034258682e0e4c169a907
12 changes: 7 additions & 5 deletions bin/signalk-server
Original file line number Diff line number Diff line change
@@ -18,13 +18,15 @@

const { engines } = require('../package.json');
const semver = require('semver');
const minimumVersion = engines.node;
const recommendedVersion = "18";

const version = engines.node;

if (!semver.satisfies(process.version, version)) {
console.log(`The installed version of node (${process.version}) is older than the required minimum version (${version}). See https://github.com/SignalK/signalk-server/wiki/Updating-to-Node.js-18 for more information how to upgrade.`);
if (!semver.satisfies(process.version, minimumVersion)) {
console.error(`The installed version of node (${process.version}) is older than the minimum required version (${minimumVersion}). See https://github.com/SignalK/signalk-server/wiki/Installing-and-Updating-Node.js for more information how to upgrade.`);
process.exit(1);
}
} else if (!semver.satisfies(process.version, recommendedVersion)) {
console.warn(`The installed version of node (${process.version}) is different than the recommended version (${recommendedVersion}). See https://github.com/SignalK/signalk-server/wiki/Installing-and-Updating-Node.js for more information how to upgrade.`);
}

const Server = require('../lib')
const server = new Server()
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -60,7 +60,7 @@
],
"license": "Apache-2.0",
"engines": {
"node": ">=18"
"node": ">=16"
},
"workspaces": [
"packages/server-admin-ui-dependencies",