Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run tests with node 16,18 and 20 #1584

Merged
merged 1 commit into from
Nov 2, 2023
Merged

chore: run tests with node 16,18 and 20 #1584

merged 1 commit into from
Nov 2, 2023

Conversation

tkurki
Copy link
Member

@tkurki tkurki commented Jul 20, 2023

In preparation for phasing out 16 and eventual adoption of 20 let's run tests with all these versions for now.

@KEGustafsson
Copy link
Contributor

KEGustafsson commented Jul 21, 2023

Started to test with Node20 LTS in Docker and noticed build time issues with following SK library, which was not compatible with 20.

-    "eslint-plugin-jsdoc": "^39.3.6",
+    "eslint-plugin-jsdoc": "^46.4.4",

Otherwise seems to run OK and didn't updated node_modules from Node18 LTS. Seems to be very transparent update.

@tkurki
Copy link
Member Author

tkurki commented Jul 21, 2023

”Issues” ?

@KEGustafsson
Copy link
Contributor

KEGustafsson commented Jul 21, 2023

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '^14 || ^16 || ^17 || ^18 || ^19' },
npm WARN EBADENGINE   current: { node: 'v20.4.0', npm: '9.8.1' }

So far only signalk-ruuvitag-plugin required a new compilation due to changed engine.

@tkurki
Copy link
Member Author

tkurki commented Jul 22, 2023

Removed the jsdoc plugin in 9611319, as I think we don't need it.

@panaaj any ideas about the test that seems to be actually failing with node 20? Works on my machine, fails in github.

@tkurki tkurki force-pushed the test-newer-nodes branch from f3abeeb to e28053f Compare July 22, 2023 19:36
@panaaj
Copy link
Member

panaaj commented Jul 23, 2023

@panaaj any ideas about the test that seems to be actually failing with node 20? Works on my machine, fails in github.

I have also tried it locally, also without error.
The error indicates that HTML was returned and not JSON. Trolling the code... all errors are 4xx status within a JSON message.
Pity it doesn't show the full message recieved... this may contain some clues.

Note The Freeboard-SK repo is also experiencing a similar issue, no errors locally but issues with NPM library in github after previously working OK.

@tkurki tkurki added other and removed chore labels Nov 2, 2023
@tkurki
Copy link
Member Author

tkurki commented Nov 2, 2023

Rebased on master, all green now!

@tkurki tkurki merged commit 57ae356 into master Nov 2, 2023
@tkurki tkurki deleted the test-newer-nodes branch November 2, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants