-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Fix #1
base: main
Are you sure you want to change the base?
Minor Fix #1
Conversation
Reviewer's Guide by SourceryThis pull request introduces two minor but important changes: adding an FFMPEG buildpack to the Heroku deployment configuration and fixing the Heroku deploy template URL in the README file. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Salxchange - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -12,13 +12,24 @@ | |||
"success_url": "https://t.me/FZXParadox", | |||
"env": { | |||
"REPO_URL": { | |||
"description": "Deploy Repository URL, add Private Token if Repo is Private" | |||
"description": "Deploy Repository URL, add Private Token if Repo is Private", | |||
"value": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider if default values should be set for environment variables.
Setting default values for environment variables can help avoid runtime errors if the variables are not provided. If these values are intentionally left empty, consider adding a comment explaining why.
"value": "" | |
"value": "" // Default value set to empty string to avoid runtime errors if not provided |
Added FFMPEG buildpack for Heroku Deploy
Fixed Heroku Deploy Template URL
Summary by Sourcery
This pull request updates the Heroku deployment configuration by adding an FFMPEG buildpack and fixes the Heroku deploy template URL in the README.