Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fix #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Minor Fix #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa7576c
Update README.md
Salxchange Jun 11, 2024
0918483
Update app.json
Salxchange Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ A Simple **.sh & .py Script** with python web to make your Repo Deployable to He

<div align="center">

[![Deploy](https://www.herokucdn.com/deploy/button.svg)](http://heroku.com/deploy?template=https://github.com/SilentDemonSD/pyTele-Loader)
[![Deploy](https://www.herokucdn.com/deploy/button.svg)](https://dashboard.heroku.com/new-app?template=https://github.com/Salxchange/pyTele-Loader)

</div

Expand Down
19 changes: 15 additions & 4 deletions app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,24 @@
"success_url": "https://t.me/FZXParadox",
"env": {
"REPO_URL": {
"description": "Deploy Repository URL, add Private Token if Repo is Private"
"description": "Deploy Repository URL, add Private Token if Repo is Private",
"value": ""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider if default values should be set for environment variables.

Setting default values for environment variables can help avoid runtime errors if the variables are not provided. If these values are intentionally left empty, consider adding a comment explaining why.

Suggested change
"value": ""
"value": "" // Default value set to empty string to avoid runtime errors if not provided

},
"REPO_BRANCH": {
"description": "Repo Branch, you want to deploy with your REPO_URL."
"description": "Repo Branch, you want to deploy with your REPO_URL.",
"value": ""
},
"START_CMD": {
"description": "Trigger Command for your Bot to Run."
"description": "Trigger Command for your Bot to Run.",
"value": ""
}
}
},
"buildpacks": [
{
"url": "heroku/python"
},
{
"url": "https://github.com/jonathanong/heroku-buildpack-ffmpeg-latest.git"
}
]
}