-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bits Helper #939
Bits Helper #939
Conversation
src/main/java/de/hysky/skyblocker/utils/container/ContainerSolverManager.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/BitsHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/BitsHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/BitsHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/BitsHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/BitsHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/BitsHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/BitsHelper.java
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/BitsHelper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method and field order are a bit confusing. For example addToTooltip
-> calculateBestItems
-> calculateBestInCategory
-> processCategory
jumps all over the place. Fields should also be placed first.
src/main/java/de/hysky/skyblocker/config/configs/HelperConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/TooltipInfoType.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/BitsHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/BitsHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/BitsHelper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but can you rebase this. If you don't I'll rebase it, but it'll say authored by you and committed by me.
src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/BitsHelper.java
Outdated
Show resolved
Hide resolved
This is good but it seems like the rebase didn't work. While you're on your
Again, you can ask me to do it if you have any problems. |
…/BitsHelper.java Co-authored-by: Kevin <[email protected]>
a22eb20
to
ee74274
Compare
Thanks for your contribution, but I think the code quality could be improved. I cleaned up some conventions, and you could look at my commits. I'll look at the algorithm parts later, but it seems a bit overly complicated. Next time when writing a feature or algorithm, I suggest thinking through or designing the algorithm on paper first before jumping into code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll just approve this. This doesn't affect other stuff anyway.
Shows you best coins per bit and highlights them
Supports showing quick selling items (green), as well as best of all (yellow)
Took me way longer than it should've taken tbh