-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SlicerCineTrack extension #2030
Conversation
Thank you for your contribution! Before we can review the extension in detail, you need to make sure that it is fully built by using the top-level CMakeLists.txt file. You provided a Visual Studio project file, but that is not included in the build and anyway it would only work on Windows. If you need the TrackingDataProcessor executable then you can very easily make it a Slicer CLI module that is automatically built on all platforms. You can use any of the CLI modules in Slicer core as an example. |
Hi @lassoan |
Hi @jcfr, |
I took a quick look and it seems nice, but it's not really clear what "Track" refers to - it would help to have a few screenshots or ideally an animated gif in the readme indicating exactly what sorts of things are being tracked. |
Hi @pieper, |
Thanks @haphantran , the images and descriptions are much better now. One suggestion is that the name doesn't quite tell me what the extension does. Maybe SlicerCineTrack or Slicer4DTrack would make it easier for people to discover? |
Hi @pieper, |
I think this is looking good - just a lint issue https://github.com/Slicer/ExtensionsIndex/actions/runs/9089156174/job/24997747489?pr=2030 any more suggestions @lassoan ? |
HI team, |
I'd be okay with merging and sorting out any remaining issues in the context of preview builds. |
Hello! Just checking in on the merge. Could we get this prioritized? Thanks in advance. |
SlicerCineTrack.json
Outdated
"$schema": "https://raw.githubusercontent.com/Slicer/Slicer/main/Schemas/slicer-extension-catalog-entry-schema-v1.0.0.json#", | ||
"build_dependencies": [], | ||
"build_subdirectory": ".", | ||
"category": "SlicerCineTrack", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Category name cannot contain Slicer
(all extensions are for Slicer). CineTrack
as category name would be too specific (it is not useful to have an category that only contains a single extension). Sequences
, 4D imaging
or Time sequence
or Registration
could be better category names.
"category": "SlicerCineTrack", | |
"category": "Sequences", |
Thank you for your patience. I've tested the extension build and it worked well. Then tried to test it but it was not clear what input data can be used (and there was no link to a sample data set). This is not a hard requirement for integration, but without it users have no chance of figuring out how to use the extension. To be fixed before integration:
Further recommendations:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, it is good to go then.
Perfect, thank you very much! |
New extension
3d-slicer-extension
GitHub topic so that it is listed here. To edit topics, click the settings icon in the right side of "About" section header and enter3d-slicer-extension
in "Topics" and click "Save changes". To learn more about topics, read https://help.github.com/en/articles/about-topicsSettings
and in repository settings uncheckWiki
,Projects
, andDiscussions
(if they are currently not used)About
in the top-right corner of the repository main page and uncheckReleases
andPackages
(if they are currently not used)