Update code to move the packages installation until user select + change extension category #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge extension category
teomesrkhani
approved these changes
Jun 27, 2024
Track/utils/TrackLogic.py
Outdated
| try: | ||
| import openpyxl | ||
| except ModuleNotFoundError: | ||
| if slicer.util.confirmOkCancelDisplay(f"To load {fileName}, install the 'xlrd' Python package. Click OK to install now."): |
There was a problem hiding this comment.
Please change 'xlrd' to 'openpyxl' for this confirmation text on line 134. Thanks!
Qreign
approved these changes
Jun 27, 2024
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the current extension to be able to publish on Extension Index. Here is the requirements:
Slicer/ExtensionsIndex#2030 (comment)
Please review!.