Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update warning to /sf versions #4096

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

WalshyDev
Copy link
Member

@WalshyDev WalshyDev commented Jan 16, 2024

Description

Adds a "Update available" to /sf versions if someone isn't on the latest Slimefun version. Hovering over will tell the user they should update and not to report bugs on this version.

Needs Slimefun/dough#245 merged

Proposed changes

Check if we're on the latest version in the versions command and if not, send a update available message.

image
image

Related Issues (if applicable)

N/A

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

TODO

  • Update dough

@WalshyDev WalshyDev requested a review from a team as a code owner January 16, 2024 12:29
@github-actions github-actions bot added the 🧹 Chores Refactoring / Cleanup. label Jan 16, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "🧹 Chores"
Thank you for contributing to this project! ❤️

Copy link
Contributor

github-actions bot commented Jan 16, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 2960136a

https://preview-builds.walshy.dev/download/Slimefun/4096/2960136a

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Sfiguz7
Sfiguz7 previously approved these changes Jan 17, 2024
@WalshyDev WalshyDev force-pushed the chore/add-update-warning-to-versions branch from 5e240e0 to d2847a7 Compare January 17, 2024 19:26
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@Sfiguz7 Sfiguz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never clicked approve on this, my bad

@WalshyDev WalshyDev merged commit 86fa6f8 into master Feb 10, 2024
16 checks passed
@WalshyDev WalshyDev deleted the chore/add-update-warning-to-versions branch February 10, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Chores Refactoring / Cleanup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants