Move the action out of ActionArgs and directly into the tick FnMut. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriyDev
force-pushed
the
expose-action
branch
from
ddd89cb to
578e963
Compare
This make it much more obvious what you're actually supposed to be doing in the tick FnMut.
andriyDev
force-pushed
the
expose-action
branch
from
578e963 to
683152e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make it much more obvious what you're actually supposed to be doing in the tick FnMut. Instead of the action being hidden away, it is the first argument. Similarly, blackboard has been moved up since in many cases you don't need to deal with the event or the dt (just returning RUNNING or Success/Failure is good enough).