Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flag to Disable Automatic Upgrades in Script #233

Merged

Conversation

sachinkum0009
Copy link
Contributor

This pull request introduces a new command-line flag --disable-upgrade to control the automatic upgrade process during the script execution.

This enhancement provides more control over the upgrade process, particularly useful in environments where upgrades need to be managed separately or manually.

@mamueluth
Copy link
Member

LGTM just some nitpicking on the help message.

@mamueluth
Copy link
Member

Thanks for the nice work:)

Copy link
Contributor

@muritane muritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed in the first review: remove this flag from import verb as it is not used there and therefore not needed

mamueluth
mamueluth previously approved these changes Sep 3, 2024
rtwcli/rtw_cmds/rtw_cmds/workspace/create_verb.py Outdated Show resolved Hide resolved
rtwcli/rtw_cmds/rtw_cmds/workspace/import_verb.py Outdated Show resolved Hide resolved
@mamueluth mamueluth merged commit 754f3fa into StoglRobotics:master Sep 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants