-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flag to Disable Automatic Upgrades in Script #233
Merged
mamueluth
merged 6 commits into
StoglRobotics:master
from
sachinkum0009:feature/add-disable-upgrade-flag
Sep 3, 2024
Merged
Add Flag to Disable Automatic Upgrades in Script #233
mamueluth
merged 6 commits into
StoglRobotics:master
from
sachinkum0009:feature/add-disable-upgrade-flag
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM just some nitpicking on the help message. |
Thanks for the nice work:) |
muritane
requested changes
Sep 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed in the first review: remove this flag from import verb as it is not used there and therefore not needed
mamueluth
previously approved these changes
Sep 3, 2024
mamueluth
approved these changes
Sep 3, 2024
muritane
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new command-line flag
--disable-upgrade
to control the automatic upgrade process during the script execution.This enhancement provides more control over the upgrade process, particularly useful in environments where upgrades need to be managed separately or manually.