Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flag to Disable Automatic Upgrades in Script #233

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Add Flag to Disable Automatic Upgrades in Script #233

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5d1a53e
disable upgrade flag added
sachinkum0009 Aug 29, 2024
2141f39
style: fix E303 by removing extra blank lines in create_verb.py
sachinkum0009 Aug 30, 2024
89518e4
Remove mistakenly added disable_upgrade parameter from generate_rocke…
sachinkum0009 Aug 30, 2024
f9b2983
:zap: removed disable upgrade flag from import verb
sachinkum0009 Sep 2, 2024
9c1bb7d
remove disable upgrade flag from import
mamueluth Sep 3, 2024
342afba
Update rtwcli/rtw_cmds/rtw_cmds/workspace/create_verb.py
mamueluth Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion rtwcli/rtw_cmds/rtw_cmds/workspace/create_verb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ class CreateVerbArgs:
repos_no_skip_existing: bool = False
disable_nvidia: bool = False
docker: bool = False
disable_upgrade: bool = False

@property
def ws_name(self) -> str:
Expand Down Expand Up @@ -385,6 +386,12 @@ def add_arguments(self, parser: argparse.ArgumentParser, cli_name: str):
help="Disable nvidia rocker flag",
default=False,
)
parser.add_argument(
"--disable-upgrade",
action="store_true",
help="Disable upgrade flag",
mamueluth marked this conversation as resolved.
Show resolved Hide resolved
default=False,
)
parser.add_argument(
"--ws-repos-file-name",
type=str,
Expand Down Expand Up @@ -601,7 +608,7 @@ def generate_intermediate_dockerfile_content(self, create_args: CreateVerbArgs)
return textwrap.dedent(
f"""
FROM {create_args.base_image_name}
RUN apt-get update && apt-get upgrade -y
RUN apt-get update {"&& apt-get upgrade -y" if not create_args.disable_upgrade else ""}
{apt_packages_cmd}
{python_packages_cmd}
{rtw_clone_cmd}
Expand Down
8 changes: 8 additions & 0 deletions rtwcli/rtw_cmds/rtw_cmds/workspace/import_verb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class ImportVerbArgs:
standalone_docker_image: str
docker: bool = True
disable_nvidia: bool = False
disable_upgrade: bool = False
standalone: bool = True
final_image_name: str = ""
container_name: str = ""
Expand Down Expand Up @@ -88,6 +89,12 @@ def add_arguments(self, parser: argparse.ArgumentParser, cli_name: str):
help="Disable nvidia rocker flag",
default=False,
)
parser.add_argument(
"--disable-upgrade",
action="store_true",
help="Disable upgrade flag",
mamueluth marked this conversation as resolved.
Show resolved Hide resolved
default=False,
)
parser.add_argument(
"--final-image-name",
type=str,
Expand Down Expand Up @@ -134,6 +141,7 @@ def main(self, *, args):
import_args = ImportVerbArgs(**filtered_args)
rocker_flags = generate_rocker_flags(
disable_nvidia=import_args.disable_nvidia,
disable_upgrade=import_args.disable_upgrade,
container_name=import_args.container_name,
hostname=import_args.hostname,
ssh_abs_path=import_args.ssh_abs_path,
Expand Down
Loading