Fix CI Failures #60
Merged
Fix CI Failures #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valerauko
approved these changes
Jan 17, 2025
| @@ -112,9 +112,11 @@ jobs: | |||
| BUNDLE_GEMFILE: ${{ github.workspace }}/.github/gemfiles/rails-${{ matrix.rails }}.Gemfile | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions/checkout@v4 | |||
Comment on lines
5
to
+6
| gem "rails", "7.0.4.3" | ||
| gem 'concurrent-ruby', '1.3.4' |
There was a problem hiding this comment.
別のPRでもかまわんけど、対応するrailsバージョンは更新しましょう
scimaenaga/.github/workflows/test.yaml
Lines 60 to 62 in 0c5cacc
不要になる
- 5系
- 6系
追加
※ actionファイルでは「サポートされてる系統（マイナー）の最新２つ」と書いてあるのでそれに合わせましょう
- 7.1
- 7.2
- 8.0
これなら今回の対応は7.0系しか必要ない
| with: | ||
| fetch-depth: 0 | ||
| - name: install libsqlite3-dev | ||
| run: sudo apt-get install libsqlite3-dev |
This was referenced Jan 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and Why
1: Can not build sqlite3
→ ubuntu 24.04.1 does not include libsqlite3-dev.
→ add
sudo apt-get install libsqlite3-dev2: rails db:setup fails
→ concurrent-ruby 1.3.5 has breaking changes. When use it with Rails < 7.1, rails command will fail.
→ use
concurrent-ruby 1.3.4