Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manipulator #10434

Closed
wants to merge 42 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
c127927
manipulator
LudwigVonChesterfield Nov 27, 2022
1fe5651
span issues
LudwigVonChesterfield Nov 27, 2022
8ea345d
issignaler
LudwigVonChesterfield Nov 27, 2022
795c86f
global consts
LudwigVonChesterfield Nov 27, 2022
8a81e49
Merge branch 'master' of https://github.com/TauCetiStation/TauCetiCla…
LudwigVonChesterfield Jun 2, 2023
e8ecec3
no sprite updates for manipulator mob.
LudwigVonChesterfield Jun 2, 2023
793160b
better code
LudwigVonChesterfield Jun 2, 2023
cfe7348
no life
LudwigVonChesterfield Jun 2, 2023
0d47f0a
fixes rotation runtime
LudwigVonChesterfield Jun 3, 2023
aff0add
added crafting to autolathe
LudwigVonChesterfield Jun 3, 2023
0b56af4
fix manipulator opening browsers.
LudwigVonChesterfield Jun 3, 2023
07d49bf
choose manipulator target zone via wires
LudwigVonChesterfield Jun 4, 2023
5612855
fix click delay issues.
LudwigVonChesterfield Jun 4, 2023
d3ce6ed
drop everything from click mob's inventory after click.
LudwigVonChesterfield Jun 4, 2023
31e92fb
fixes human list issue.
LudwigVonChesterfield Jun 4, 2023
a1db80f
removing manipulator mob from mob lists
LudwigVonChesterfield Jun 4, 2023
ca0909d
drop items only after complete activation
LudwigVonChesterfield Jun 4, 2023
d0092d5
fixes not being able to pulse change target zone
LudwigVonChesterfield Jun 4, 2023
35410a0
gives manipulator max skills
LudwigVonChesterfield Jun 4, 2023
41f810b
adds manipulator self attack capability, forced attack hand click.
LudwigVonChesterfield Jun 5, 2023
0d122f7
little emag feature
LudwigVonChesterfield Jun 5, 2023
a030c3d
cutting activation wire will make manipulator not activate automatica…
LudwigVonChesterfield Jun 6, 2023
7109242
prohibitting unwrenching while working
LudwigVonChesterfield Jun 6, 2023
dd65365
manipulator elements(hand and item) are not clickable, thus causing l…
LudwigVonChesterfield Jun 6, 2023
f58b9a1
naming support, personalization.
LudwigVonChesterfield Jun 6, 2023
cd44726
googly perfection
LudwigVonChesterfield Jun 6, 2023
8d62594
fixes wire issue
LudwigVonChesterfield Jun 7, 2023
f343eb3
Revert "fixes human list issue." Since mob is deleted from lists anyway.
LudwigVonChesterfield Jun 7, 2023
470c0bf
removes processing from SSmobs, removes simulated check in Life
LudwigVonChesterfield Jun 7, 2023
148d54f
Revert "removes processing from SSmobs, removes simulated check in Life"
LudwigVonChesterfield Jun 7, 2023
34dc9fa
adding missing after_activate
LudwigVonChesterfield Jun 7, 2023
5677fa5
the activator won't send after activation signal if nothing actually …
LudwigVonChesterfield Jun 8, 2023
af6ac51
you can't pulse cut wires, so auto activation is seperate now
LudwigVonChesterfield Jun 8, 2023
d127a1b
Merge branch 'master' into maniwhat_now
LudwigVonChesterfield Jun 16, 2023
3518c60
Merge branch 'master' of https://github.com/TauCetiStation/TauCetiCla…
LudwigVonChesterfield Aug 13, 2023
d7e979f
Merge branch 'maniwhat_now' of https://github.com/TauCetiStation/TauC…
LudwigVonChesterfield Aug 13, 2023
8a13f8e
ghosts can't mirror
LudwigVonChesterfield Aug 13, 2023
6ab4da7
Merge branch 'master' of https://github.com/TauCetiStation/TauCetiCla…
LudwigVonChesterfield Dec 6, 2023
6f05597
balance patches
LudwigVonChesterfield Dec 6, 2023
6e0b182
just one more thing
LudwigVonChesterfield Dec 6, 2023
2ba250b
fixes unwrenching
LudwigVonChesterfield Dec 6, 2023
35e087d
Merge branch 'master' of https://github.com/TauCetiStation/TauCetiCla…
LudwigVonChesterfield Mar 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix manipulator opening browsers.
LudwigVonChesterfield committed Jun 3, 2023
commit 0b56af4c3de81c4b996cd24eb4a6bccaa56c97aa
7 changes: 7 additions & 0 deletions code/datums/browser.dm
Original file line number Diff line number Diff line change
@@ -17,6 +17,10 @@
var/mob/M = nuser
nuser = M.client

if(!nuser)
qdel(src)
return
Comment on lines +20 to +22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

подавление возможных валидных ошибок

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не могу придумать как проверять что клиент принадлежит манипулятору.

сначала думал строку-затычку но потом понял что все проверки вида if(user.client) будут проходить при том что не должны.

какие-то есть возможные решения кроме поиска всех случаев когда создаётся браузер?...

и даже если я везде буду проверять на клиента ДО создания браузера, единственная "валидная" ошибка которую мы сейчас подавляем это "кто-то создал браузер без юзера"


user = nuser
LAZYSET(user.browsers, nwindow_id, src)
window_id = nwindow_id
@@ -92,6 +96,9 @@
</html>"}

/datum/browser/proc/open()
if(!user)
return

var/window_size
if(width && height)
window_size = "size=[width]x[height];"