-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manipulator #10434
Closed
Closed
Manipulator #10434
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
c127927
manipulator
LudwigVonChesterfield 1fe5651
span issues
LudwigVonChesterfield 8ea345d
issignaler
LudwigVonChesterfield 795c86f
global consts
LudwigVonChesterfield 8a81e49
Merge branch 'master' of https://github.com/TauCetiStation/TauCetiCla…
LudwigVonChesterfield e8ecec3
no sprite updates for manipulator mob.
LudwigVonChesterfield 793160b
better code
LudwigVonChesterfield cfe7348
no life
LudwigVonChesterfield 0d47f0a
fixes rotation runtime
LudwigVonChesterfield aff0add
added crafting to autolathe
LudwigVonChesterfield 0b56af4
fix manipulator opening browsers.
LudwigVonChesterfield 07d49bf
choose manipulator target zone via wires
LudwigVonChesterfield 5612855
fix click delay issues.
LudwigVonChesterfield d3ce6ed
drop everything from click mob's inventory after click.
LudwigVonChesterfield 31e92fb
fixes human list issue.
LudwigVonChesterfield a1db80f
removing manipulator mob from mob lists
LudwigVonChesterfield ca0909d
drop items only after complete activation
LudwigVonChesterfield d0092d5
fixes not being able to pulse change target zone
LudwigVonChesterfield 35410a0
gives manipulator max skills
LudwigVonChesterfield 41f810b
adds manipulator self attack capability, forced attack hand click.
LudwigVonChesterfield 0d122f7
little emag feature
LudwigVonChesterfield a030c3d
cutting activation wire will make manipulator not activate automatica…
LudwigVonChesterfield 7109242
prohibitting unwrenching while working
LudwigVonChesterfield dd65365
manipulator elements(hand and item) are not clickable, thus causing l…
LudwigVonChesterfield f58b9a1
naming support, personalization.
LudwigVonChesterfield cd44726
googly perfection
LudwigVonChesterfield 8d62594
fixes wire issue
LudwigVonChesterfield f343eb3
Revert "fixes human list issue." Since mob is deleted from lists anyway.
LudwigVonChesterfield 470c0bf
removes processing from SSmobs, removes simulated check in Life
LudwigVonChesterfield 148d54f
Revert "removes processing from SSmobs, removes simulated check in Life"
LudwigVonChesterfield 34dc9fa
adding missing after_activate
LudwigVonChesterfield 5677fa5
the activator won't send after activation signal if nothing actually …
LudwigVonChesterfield af6ac51
you can't pulse cut wires, so auto activation is seperate now
LudwigVonChesterfield d127a1b
Merge branch 'master' into maniwhat_now
LudwigVonChesterfield 3518c60
Merge branch 'master' of https://github.com/TauCetiStation/TauCetiCla…
LudwigVonChesterfield d7e979f
Merge branch 'maniwhat_now' of https://github.com/TauCetiStation/TauC…
LudwigVonChesterfield 8a13f8e
ghosts can't mirror
LudwigVonChesterfield 6ab4da7
Merge branch 'master' of https://github.com/TauCetiStation/TauCetiCla…
LudwigVonChesterfield 6f05597
balance patches
LudwigVonChesterfield 6e0b182
just one more thing
LudwigVonChesterfield 2ba250b
fixes unwrenching
LudwigVonChesterfield 35e087d
Merge branch 'master' of https://github.com/TauCetiStation/TauCetiCla…
LudwigVonChesterfield File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
var/global/const/MANIPULATOR_WIRE_ACTIVATE = 1 | ||
var/global/const/MANIPULATOR_WIRE_AFTER_ACTIVATE = 2 | ||
var/global/const/MANIPULATOR_WIRE_CHANGE_TARGET_ZONE = 4 | ||
var/global/const/MANIPULATOR_WIRE_ATTACK_SELF_ON_INTERACTION = 8 | ||
var/global/const/MANIPULATOR_WIRE_AUTO_ACTIVATION = 16 | ||
|
||
/datum/wires/manipulator | ||
holder_type = /obj/machinery/manipulator | ||
wire_count = 5 | ||
window_y = 560 | ||
|
||
/datum/wires/manipulator/can_use() | ||
var/obj/machinery/manipulator/M = holder | ||
return M.panel_open | ||
|
||
/datum/wires/manipulator/get_status() | ||
var/obj/machinery/manipulator/M = holder | ||
. += ..() | ||
. += "Target selection screen displays: [parse_zone(M.target_zone)]" | ||
. += "The 'Activate Instead' light is [M.attack_self_interaction ? "on" : "off"]." | ||
. += "The 'Auto Activation' light is [M.auto_activation ? "on" : "off"]." | ||
|
||
/datum/wires/manipulator/update_cut(index, mended) | ||
var/obj/machinery/manipulator/M = holder | ||
|
||
switch(index) | ||
if(MANIPULATOR_WIRE_AUTO_ACTIVATION) | ||
M.auto_activation = mended | ||
return | ||
|
||
if(MANIPULATOR_WIRE_ATTACK_SELF_ON_INTERACTION) | ||
M.attack_self_interaction = !mended | ||
return | ||
|
||
update_pulsed(index) | ||
|
||
/datum/wires/manipulator/update_pulsed(index) | ||
var/obj/machinery/manipulator/M = holder | ||
|
||
switch(index) | ||
if(MANIPULATOR_WIRE_ACTIVATE) | ||
if(!M.can_activate()) | ||
return | ||
|
||
M.forced = TRUE | ||
M.activate() | ||
|
||
if(MANIPULATOR_WIRE_CHANGE_TARGET_ZONE) | ||
M.cycle_target_zone() | ||
|
||
if(MANIPULATOR_WIRE_ATTACK_SELF_ON_INTERACTION) | ||
M.next_attack_self_interaction = TRUE |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -459,6 +459,8 @@ | |
|
||
/client/var/list/image/outlined_item = list() | ||
/atom/movable/proc/apply_outline(color) | ||
if(!usr || !usr.client) | ||
return | ||
Comment on lines
+462
to
+463
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. подавление возможных валидных ошибок x2, и так далее. |
||
if(anchored || !usr.client.prefs.outline_enabled) | ||
return | ||
if(!color) | ||
|
@@ -479,6 +481,8 @@ | |
|
||
|
||
/atom/movable/proc/remove_outline() | ||
if(!usr || !usr.client) | ||
return | ||
usr.client.images -= usr.client.outlined_item[src] | ||
usr.client.outlined_item -= src | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
подавление возможных валидных ошибок
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
не могу придумать как проверять что клиент принадлежит манипулятору.
сначала думал строку-затычку но потом понял что все проверки вида if(user.client) будут проходить при том что не должны.
какие-то есть возможные решения кроме поиска всех случаев когда создаётся браузер?...
и даже если я везде буду проверять на клиента ДО создания браузера, единственная "валидная" ошибка которую мы сейчас подавляем это "кто-то создал браузер без юзера"