chore(Playroom): upgrade version #1016
Conversation
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit d9ff546. |
| @@ -32,8 +32,8 @@ | |||
| "storybook-for-acceptance-tests": "cross-env NODE_ENV=production yarn storybook --ci 2>&1", | |||
| "playroom": "playroom start", | |||
| "gen-ts-defs": "rimraf dist-ts && tsc --project tsconfig.production.json --emitDeclarationOnly && cp -r dist-ts/src/* dist && rimraf dist-ts", | |||
| "vercel-build": "VERCEL_PROD_BUILD=1 yarn storybook-static && ./node_modules/.bin/playroom build && FORCE_MOBILE=1 ./node_modules/.bin/playroom build && FORCE_DESKTOP=1 ./node_modules/.bin/playroom build && cp img/favicon.ico public/", | |||
| "vercel-preview-build": "yarn storybook-static && ./node_modules/.bin/playroom build && cp img/favicon.ico public/", | |||
| "vercel-build": "VERCEL_PROD_BUILD=1 yarn storybook-static && ./node_modules/.bin/playroom build && FORCE_MOBILE=1 ./node_modules/.bin/playroom build && FORCE_DESKTOP=1 ./node_modules/.bin/playroom build && cp img/favicon.ico public/ && cp img/favicon.svg public/", | |||
There was a problem hiding this comment.
when upgrading storybook to v7, the mistica's favicon stopped working. It seems that storybook replaced the .ico file with a .svg.
| @@ -107,7 +107,7 @@ const config = { | |||
| type: 'asset/resource', | |||
| }, | |||
| { | |||
| test: /\.vanilla\.css$/i, | |||
| test: /\.vanilla\.css/i, | |||
There was a problem hiding this comment.
After the upgrade, I was getting a lot of errors when trying to start playroom. It looks like there are some characters being added to the end of the filenames for vanilla css files.
|
🎉 This PR is included in version 14.43.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue: Link
Remark: it looks like the playroom's site favicon is now the playroom logo instead of Mistica's one. I believe this is caused by this PR in their repo. I've created an issue for them so that they review this.