Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Playroom): upgrade version #1016

Merged
merged 6 commits into from
Feb 19, 2024
Merged

chore(Playroom): upgrade version #1016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
00257c3
upgrade playroom version
marcoskolodny Feb 6, 2024
6499857
fix storybook favicon
marcoskolodny Feb 7, 2024
bb4af3c
fix svg
marcoskolodny Feb 7, 2024
fb7aa9b
test playroom icon
marcoskolodny Feb 7, 2024
f7e8a7b
test
marcoskolodny Feb 7, 2024
d9ff546
remove test
marcoskolodny Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed .yarn/cache/@babel-cli-npm-7.20.7-4e13a4a61e-162d9645b8.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/@babel-parser-npm-7.23.9-720a0b56cb-e7cd4960ac.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/@babel-standalone-npm-7.20.12-264d3850e3-dcf7220672.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/@nicolo-ribaudo-chokidar-2-npm-2.1.8-no-fsevents.3-79ca8bfcef-ee55cc9241.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/any-promise-npm-1.3.0-f34eeaa7e7-0ee8a9bdbe.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/fs-readdir-recursive-npm-1.1.0-258e230a4b-29d50f3d21.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/memoize-one-npm-6.0.0-8b2a2cd020-f185ea69f7.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/mz-npm-2.7.0-ec3cef4ec2-8427de0ece.zip
View file
Open in desktop
Binary file not shown.
Binary file renamed ...room-npm-0.31.0-eb6d5e7595-f5965a0946.zip → ...room-npm-0.34.2-e9f7c73b5f-b4c1886c9f.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/slash-npm-2.0.0-69009eac54-512d435073.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/sucrase-npm-3.35.0-60ad876a0c-9fc5792a9a.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/thenify-all-npm-1.6.0-96309bbc8b-dba7cc8a23.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/thenify-npm-3.3.1-030bedb22c-84e1b804bf.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/ts-interface-checker-npm-0.1.13-0c7b064494-20c29189c2.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/typescript-npm-5.3.3-6b23a5da18-2007ccb6e5.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/typescript-patch-47de0b8a47-f61375590b.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/use-debounce-npm-9.0.2-8b3a88c5d1-fb7d9a263e.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/use-debounce-npm-9.0.4-b60c0014f6-37da4ecbe4.zip
View file
Open in desktop
Binary file not shown.
37 changes: 37 additions & 0 deletions img/favicon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"storybook-for-acceptance-tests": "cross-env NODE_ENV=production yarn storybook --ci 2>&1",
"playroom": "playroom start",
"gen-ts-defs": "rimraf dist-ts && tsc --project tsconfig.production.json --emitDeclarationOnly && cp -r dist-ts/src/* dist && rimraf dist-ts",
"vercel-build": "VERCEL_PROD_BUILD=1 yarn storybook-static && ./node_modules/.bin/playroom build && FORCE_MOBILE=1 ./node_modules/.bin/playroom build && FORCE_DESKTOP=1 ./node_modules/.bin/playroom build && cp img/favicon.ico public/",
"vercel-preview-build": "yarn storybook-static && ./node_modules/.bin/playroom build && cp img/favicon.ico public/",
"vercel-build": "VERCEL_PROD_BUILD=1 yarn storybook-static && ./node_modules/.bin/playroom build && FORCE_MOBILE=1 ./node_modules/.bin/playroom build && FORCE_DESKTOP=1 ./node_modules/.bin/playroom build && cp img/favicon.ico public/ && cp img/favicon.svg public/",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when upgrading storybook to v7, the mistica's favicon stopped working. It seems that storybook replaced the .ico file with a .svg.

"vercel-preview-build": "yarn storybook-static && ./node_modules/.bin/playroom build && cp img/favicon.ico public/ && cp img/favicon.svg public/",
"storybook-static": "rimraf public && storybook build -s ./.storybook/css/fonts -o public --quiet",
"serve-static-storybook": "node ./scripts/serve-static-storybook.js",
"detect-circular-dependencies": "npx dpdm --circular src/index.tsx",
Expand Down Expand Up @@ -123,7 +123,7 @@
"lodash": "^4.17.21",
"mini-css-extract-plugin": "^1.6.2",
"node-fetch": "^2.6.7",
"playroom": "^0.31.0",
"playroom": "^0.34.2",
"postcss": "^8.4.18",
"postcss-loader": "^4.2.0",
"prettier": "^2.6.1",
Expand Down
2 changes: 1 addition & 1 deletion playroom.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ const config = {
type: 'asset/resource',
},
{
test: /\.vanilla\.css$/i,
test: /\.vanilla\.css/i,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the upgrade, I was getting a lot of errors when trying to start playroom. It looks like there are some characters being added to the end of the filenames for vanilla css files.

MicrosoftTeams-image (1)

// Don't process vanilla files from Playroom as they are handled separately.
exclude: /node_modules\/playroom/,
use: [
Expand Down
Loading
Loading