Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WEB-2068 showLoadingOverlay / hideLoadingOverlay #152

Merged
merged 1 commit into from
Oct 14, 2024
Merged

WEB-2068 showLoadingOverlay / hideLoadingOverlay #152

merged 1 commit into from
Oct 14, 2024

Conversation

atabel
Copy link
Contributor

@atabel atabel commented Oct 8, 2024

closes #145

atabel
atabel commented Oct 8, 2024
View reviewed changes
README.md
@@ -1257,6 +1257,70 @@ Writes the given text to the clipboard
writeTextToClipboard: (text: string) => Promise<void>;
```

### showLoadingOverlay / hideLoadingOverlay
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpastor, if you have a video with a demo I can add it to the docs

Copy link
Contributor

@dpastor dpastor Oct 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have, but probably is better to wait until we merge it, adding a video with the test page @dzayas has which simulates a more real vivo flow.

atabel
atabel commented Oct 8, 2024
View reviewed changes
README.md
@@ -1257,6 +1257,70 @@ Writes the given text to the clipboard
writeTextToClipboard: (text: string) => Promise<void>;
```

### showLoadingOverlay / hideLoadingOverlay

<kbd>App version >=24.10</kbd>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this min app version ok, @dpastor ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks :)

dpastor
dpastor approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@dpastor dpastor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@atabel atabel merged commit 53bdd41 into master Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoskolodny marcoskolodny marcoskolodny approved these changes

@dpastor dpastor dpastor approved these changes

@pladaria pladaria pladaria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show/Hide Loading Overlay
4 participants
@atabel @pladaria @dpastor @marcoskolodny