-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEB-2068 showLoadingOverlay / hideLoadingOverlay #152
Merged
+171
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1257,6 +1257,70 @@ Writes the given text to the clipboard | |
writeTextToClipboard: (text: string) => Promise<void>; | ||
``` | ||
|
||
### showLoadingOverlay / hideLoadingOverlay | ||
|
||
<kbd>App version >=24.10</kbd> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this min app version ok, @dpastor ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, thanks :) |
||
|
||
Shows a loading overlay screen while a task is being performed. You can control | ||
when to hide it with the `hideLoadingOverlay` method. | ||
|
||
```ts | ||
showLoadingOverlay: ({ | ||
/** | ||
* Whether the in animation is enabled (false by default) | ||
*/ | ||
inAnimation?: boolean; | ||
/** | ||
* Whether the out animation is enabled (false by default) | ||
*/ | ||
outAnimation?: boolean; | ||
/** | ||
* Minimum duration of the loop animation in milliseconds (0 by default) | ||
*/ | ||
minimumLoopDurationMs?: number; | ||
/** | ||
* whether the loop animation should be stopped immediately or not (true by default) | ||
*/ | ||
stopAnimationCycle?: boolean; | ||
/** | ||
* Whether the background animation is enabled (false by default) | ||
*/ | ||
backgroundAnimation?: boolean; | ||
/** | ||
* List of description texts to be shown one after the other | ||
*/ | ||
descriptions?: Array<string>; | ||
/** | ||
* Duration of each description in milliseconds (3000 by default) | ||
*/ | ||
descriptionDurationMs?: number; | ||
/** | ||
* After this timeout loading screen would be hidden automatically (20000 by default) | ||
*/ | ||
timeoutMs?: number; | ||
/** | ||
* (Only Android) If true, after loading screen has been hidden, if user presses android back button, webview window will close (true by default) | ||
*/ | ||
closeOnBackButtonPressAfterFinish?: boolean; | ||
}) => Promise<void>; | ||
|
||
hideLoadingOverlay: () => Promise<void>; | ||
``` | ||
|
||
#### Example | ||
|
||
```ts | ||
await showLoadingOverlay({ | ||
inAnimation: true, | ||
outAnimation: true, | ||
stopAnimationCycle: false, | ||
descriptions: ['Loading...', 'Please wait...'], | ||
descriptionDurationMs: 3000, | ||
}); | ||
await doExpensiveTask(); | ||
await hideLoadingOverlay(); | ||
``` | ||
|
||
## Error handling | ||
|
||
If an uncontrolled error occurs, promise will be rejected with an error object: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dpastor, if you have a video with a demo I can add it to the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have, but probably is better to wait until we merge it, adding a video with the test page @dzayas has which simulates a more real vivo flow.