WIP! test: save and load

[keturn]

super kludgy test trying to troubleshoot loading

[keturn]

I think I'd made some progress figuring out Instant before I fell down a rabbit hole.

• its TypeHandler does make it in to the TypeHandlerLibrary
• extra wrinkle because the field on the component is Map<Name, Instant>
• ends up with the wrong valueTypeHandler in https://github.com/MovingBlocks/Terasology/blob/develop/subsystems/TypeHandlerLibrary/src/main/java/org/terasology/persistence/typeHandling/coreTypes/factories/MapTypeHandlerFactory.java

and that's where I went off on the tangent

one possibility is that after this mess

WildAnimals/src/test/java/org/terasology/wildAnimals/system/WildAnimalsSpawnSystemTest.java

Lines 123 to 129 in b565f2b

	// MTE does not include helpers for loading from a save file.
	// This is kludged together from StorageManagerTest internals.
	EntitySystemSetupUtil.addReflectionBasedLibraries(context);
	EntitySystemSetupUtil.addEntityManagementRelatedClasses(context);
	EngineEntityManager newEntityManager = context.getValue(EngineEntityManager.class);
	StorageManager newSM = new ReadWriteStorageManager(getSavePath(config), modules.getEnvironment(), newEntityManager, blockManager,
	extraDataManager, null, null, null);

the TypeHandlerLibrary being used by the new storage manager doesn't have the module-provided handlers in it. The test I copied it out of didn't have any external modules, so it wouldn't have noticed.

[keturn]

one possibility is that after this mess, the TypeHandlerLibrary being used by the new storage manager doesn't have the module-provided handlers in it.

Further investigation shows that to be the case. That means the errors about Instance are due to not knowing how to load from a save game in MTE, not necessarily bugs elsewhere.

[keturn]

Test case is in somewhat more useful shape now.

I think the problem now is that part of the code under test is in SkeletonRenderer, and it's never getting the newSkeleton event. I don't think OnActivatedComponent events are broken in the test in general; my current hunch is that it's because it's a RenderSystem in headless mode? Or because it has RegisterMode.CLIENT?

[keturn]

Yep, RegisterMode.CLIENT.validWhenHeadless == false. 🙁