Add helper for making RSA key from exponent and modulus #307
Conversation
- Split verify function to signature and claims - Added handling of claims set in json while creating a verifier
- Split verify function to signature and claims - Added handling of claims set in json while creating a verifier
Yes I should have removed it. Used it in testing Co-authored-by: Chris Mc <[email protected]>
|
I see you made a lot of changes. OpenSSL did deprecate the functions in v3 but it is still usable. I will test the openssl 3 changes although I wanted to do this at a later stage after the original PR is approved and with the additions for elliptic curve. |
|
We made a decent effort to remove all the deprecated function usage with OpenSSL 3.0 and it would be ideal to keep it that way. The test code you submitted passes but I do agree it needs to be tested more. I would love to fixup some of the memory management, there's a current a leak when it makes the key. it would be easier to merge this before trying to add more. I think it's getting a little bit complicated and the EC curve will need just a much fiddling to maintain support for the 5 (or 6) combination of SSL libraries we support |
|
I am pretty happy with this there's some missing negative case tests https://coveralls.io/builds/62156107/source?filename=include%2Fjwt-cpp%2Fjwt.h#L953 especially for the openssl error and I try to find sometime this week to work on those |
working on the matrix of wolfssl and libress and 1.1.0
this is theoretically only because of the test code but better safe then sorry
|
Finally found the memory leak 🚀 More improvements to actions + fixed an example 😫 worth it |
so fixup error implementation to match
its only for certs not just pubkeys
|
Finally green ✅ |
Follow up of #298 since GitHub closed the PR when I pushed and will not let me re-open 😞
I fixed the wolfSSL test not passing, I put together some code for the openssl 3.0 support
//cc @zofer1 who originally submitted this
While evaluating JWT-CPP I have found a case where we have the public key defined as modulus and exponent. I have added a wrapper function to allow this functionality and hide the openssl details for this.
I have also added adding a set of claims defined as json to a verifier to allow static configuration files in the application level.
For the case where we may apply external claims verification we only want to verify the signature only and skip the claims verification. For this I have split the verify functions accordingly while maintaining a BWC.
closes #271