fix(android): ads build and enable ads in android sample #3376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avencat
reviewed
Nov 22, 2023
freeboub
commented
Nov 23, 2023
| @@ -30,7 +30,7 @@ protected List<ReactPackage> getPackages() { | |||
| @SuppressWarnings("UnnecessaryLocalVariable") | |||
| List<ReactPackage> packages = new PackageList(this).getPackages(); | |||
| // Packages that cannot be autolinked yet can be added manually here, for example: | |||
| // packages.add(new MyReactNativePackage()); | |||
| packages.add(new ReactVideoPackage()); | |||
There was a problem hiding this comment.
@KrzysztofMoch This one was missing ! but now it work fine, thank uyou for the tips of removing react-native-video from package.json !
freeboub
requested review from
avencat and
KrzysztofMoch
and removed request for
avencat
|
ping @YangJonghun ! here is aditionnal rework from you media3 PR ! |
avencat
approved these changes
Nov 24, 2023
KrzysztofMoch
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure Sample builds correctly with IMA enable
Related issue: #3370
how to test
go to sample directory
yarn android
--> you should be able to see ads on big bug bunny sample
comment RNVUseExoplayerIMA = true
yarn android
--> you should NOT be able to see ads on big bug bunny sample (but playback works anyway !)