chore: Switch from kmp to a normal jvm library #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
robinlinden
force-pushed
the
no-more-kmp
branch
from
948ffe4 to
3ffb4e8
Compare
kmp isn't well-supported enough that we can use it yet, with a major issue right now being that the protobuf gradle plugin doesn't support kmp.
robinlinden
force-pushed
the
no-more-kmp
branch
from
3ffb4e8 to
9ca3e68
Compare
Not specifying a protoc binary like this means it uses what's installed on the system. This works fine if you're building via the docker setup, but isn't very convenient if you're working from e.g. inside Android Studio.
robinlinden
force-pushed
the
no-more-kmp
branch
from
9ca3e68 to
325989b
Compare
iphydf
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protoc change is unrelated, but makes it convenient to build jvm-toxcore-c from inside Android Studio.
This change is