Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch from kmp to a normal jvm library #131

Merged
merged 2 commits into from
Jan 1, 2025

chore: Match the protoc version w/ the protobuf in the gradle build

325989b
Select commit
Loading
Failed to load commit list.
Merged

chore: Switch from kmp to a normal jvm library #131

chore: Match the protoc version w/ the protobuf in the gradle build
325989b
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Jan 1, 2025 in 4s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : chore: Switch from kmp to a normal jvm library
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : chore: Switch from kmp to a normal jvm library

kmp isn't well-supported enough that we can use it yet, with a major
issue right now being that the protobuf gradle plugin doesn't support
kmp.,chore: Match the protoc version w/ the protobuf in the gradle build

Not specifying a protoc binary like this means it uses what's installed
on the system. This works fine if you're building via the docker setup,
but isn't very convenient if you're working from e.g. inside Android
Studio.
Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : The protoc change is unrelated, but makes it convenient to build jvm-toxcore-c from inside Android Studio.

This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}