Review of Functional Programming section #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By starting the reduction with a (0, 0) tuple, the function returned an incorrect minimum of zero if all inputs were positive or an incorrect maximum of zero if all inputs were negative. The new version assumes that the `data` vector is not empty, which is always the case here but might not be in real life. I think that's fine for an example. I also swapped `std::reduce` for `std::accumulate` to be more consistent with the rest of the text. It's sequential by default, and we're still providing an initial element, so I think it's strictly equivalent in this case, but I haven't tested it.
Again, for consistency with the rest of the text. I also believe it's strictly equivalent here, but it might be worth double-checking.
including adding hyphens to "higher-order functions"
Feel free to overrule me on this, but it felt very ad hoc to me and was not present in the C++ version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one actual bug fix (8705604) but most of the changes I propose are minor/cosmetic.
In general, I think it's a well-written section, which conveys the advantages of FP clearly and succinctly.
I'm not sure how much we actually want to expand the section. If we do, one idea would be to add an example demonstrating how FP makes it easy to parallelize computations. I'm not sure how to do this in either C++ or Python, but I'd be happy to look into it if we think that's worth it.
(ref. #134)